separation of concerns: AFP WaveView updateCursor

extract check to pointerCloseToStartEndOrLoop()
LMMS · Oct 5, 2024 · 2fd077d · 2fd077d
1 parent 6ee1990
commit 2fd077d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/plugins/AudioFileProcessor/AudioFileProcessorWaveView.cpp b/plugins/AudioFileProcessor/AudioFileProcessorWaveView.cpp
@@ -480,23 +480,28 @@ void AudioFileProcessorWaveView::reverse()
 
 void AudioFileProcessorWaveView::updateCursor(QMouseEvent * me)
 {
-	QPoint pos;
-	if (me) { pos = position(me); }
-
 	bool const waveIsDragged = m_isDragging && (m_draggingType == DraggingType::Wave);
-	bool const pointerCloseToStartEndOrLoop = (me != nullptr) &&
-			(isCloseTo(pos.x(), m_startFrameX) ||
-			  isCloseTo(pos.x(), m_endFrameX) ||
-			  isCloseTo(pos.x(), m_loopFrameX));
 
-	if (!m_isDragging && pointerCloseToStartEndOrLoop)
+	if (!m_isDragging && pointerCloseToStartEndOrLoop(me))
 		setCursor(Qt::SizeHorCursor);
 	else if (waveIsDragged)
 		setCursor(Qt::ClosedHandCursor);
 	else
 		setCursor(Qt::OpenHandCursor);
 }
 
+bool AudioFileProcessorWaveView::pointerCloseToStartEndOrLoop(QMouseEvent * me)
+{
+	if (me == nullptr)
+	{
+		return false;
+	}
+
+	const QPoint pos = position(me);
+
+	return isCloseTo(pos.x(), m_startFrameX) || isCloseTo(pos.x(), m_endFrameX) || isCloseTo(pos.x(), m_loopFrameX);
+}
+
 void AudioFileProcessorWaveView::configureKnobRelationsAndWaveViews()
 {
 	m_startKnob->setWaveView(this);

diff --git a/plugins/AudioFileProcessor/AudioFileProcessorWaveView.h b/plugins/AudioFileProcessor/AudioFileProcessorWaveView.h
@@ -171,6 +171,7 @@ public slots:
 	void updateGraph();
 	void reverse();
 	void updateCursor(QMouseEvent* me = nullptr);
+	bool pointerCloseToStartEndOrLoop(QMouseEvent* me);
 
 	void configureKnobRelationsAndWaveViews();