Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDAStopTest2 bug #339

Closed
jehelset opened this issue Sep 15, 2023 · 3 comments
Closed

IDAStopTest2 bug #339

jehelset opened this issue Sep 15, 2023 · 3 comments
Assignees
@gardner48
Labels
bug pkg-IDA pkg-IDAS
Milestone
SUNDIALS v6.7.0

Comments

@jehelset
Copy link

bfec386 moved check for tn past tstop before check for tn past tout in IDAStopTest2:
bfec386?diff=split#diff-a624e4aaf10771efab2a0c451839e9c4f24613e0f5ee296e82cf5f5bc4fcecebL2101

in a test i have a simple linear system dxdt = 1.0, and root function g(x) = 1.0 - x, doing fixed-step integration with dt = 0.1, and tstop = 1.5, at t = 0.7, instead of IDAStep computing the solution t = 0.8, like it does in version 6.6.0, it now, in 6.6.1, instead does an early return and reports stop!
@gardner48 gardner48 self-assigned this Sep 15, 2023
@gardner48
Copy link
Member

gardner48 commented Sep 15, 2023 •
edited
Loading

@jehelset thanks for reporting this issue. The change you point to, while fixing a different minor bug, did introduce a new bug that will cause an unintended return at tstop rather than at tout. I'll propose a fix for this regression shortly.

@jehelset
Copy link
Author

yes, it is a nice change otherwise. thanks!

gardner48 added a commit that referenced this issue Oct 2, 2023
@gardner48
Update CHANGELOG with fix for issue #339
17e780f
@gardner48 gardner48 mentioned this issue Oct 3, 2023
Merged
balos1 pushed a commit that referenced this issue Oct 4, 2023
@gardner48
Bugfix: stop time and output time reached in same step (#349)
e800b15 
Fixes #339: A regression was introduced by the stop time bug fix in
v6.6.1 causing integrators to return at the stop time rather than the
requested output time if the stop time was reached in the same step in
which the output time was passed.

Also fixes a missing check in ARKODE to interpolate (or not) the
solution at the stop time.
@balos1
Copy link
Member

balos1 commented Oct 4, 2023

Fixed by #349.

@balos1 balos1 closed this as completed Oct 4, 2023
@balos1 balos1 added this to the SUNDIALS Next milestone Oct 4, 2023
gardner48 added a commit that referenced this issue Dec 18, 2023
@gardner48
Bugfix: stop time and output time reached in same step (#349)
cba1fd7 
Fixes #339: A regression was introduced by the stop time bug fix in
v6.6.1 causing integrators to return at the stop time rather than the
requested output time if the stop time was reached in the same step in
which the output time was passed.

Also fixes a missing check in ARKODE to interpolate (or not) the
solution at the stop time.
balos1 pushed a commit that referenced this issue Dec 18, 2023
@gardner48 @balos1
Bugfix: stop time and output time reached in same step (#349)
8ddb1fa 
Fixes #339: A regression was introduced by the stop time bug fix in
v6.6.1 causing integrators to return at the stop time rather than the
requested output time if the stop time was reached in the same step in
which the output time was passed.

Also fixes a missing check in ARKODE to interpolate (or not) the
solution at the stop time.
@gardner48 gardner48 mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gardner48 gardner48

Labels
bug pkg-IDA pkg-IDAS
Projects
None yet
Milestone
SUNDIALS v6.7.0
Development

No branches or pull requests
3 participants
@balos1 @gardner48 @jehelset