Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting Artificial viscosity out of hydrodynamics packages into its own physics package #317

Draft
wants to merge 62 commits into
base: develop
Choose a base branch
from
Draft

Splitting Artificial viscosity out of hydrodynamics packages into its own physics package #317

wants to merge 62 commits into from

Conversation

jmikeowen
Copy link
Collaborator

Summary

  • This PR is a feature/refactoring
  • It does the following:
    • Make the ArtificialViscosity it's own physics package, working alongside the hydrodynamics package.
    • Cleans up some state usage, particularly being more rigorous about some of the artificial viscosity logic correctly time centering it's dependent state during a time advancement cycle.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen
Moving grad-h corrections to SPH::postStateUpdate to avoid mixing tim…
30d1444 
…e-levels in multi-stage integrators
@jmikeowen
Parameter change in interpolation kernel (no real change)
af2c1b1
@jmikeowen
Converted NodePairList storage in ConnectivityMap to be a shared_ptr
9a22af9
@jmikeowen
Convert NodePairList to use size_t
faf2546
@jmikeowen
Split up the NodePairIdxType and NodePairList into separate headers,
e510788 
and adding an index of NodePair->index lookup map.
@jmikeowen
Initial introduction of PairwiseField. Also split out NodePairIdxType
d83759d 
from the NodePairList header.
@jmikeowen
Using the pair->index lookup computed by NodePairList
d3093c2
@jmikeowen
Interim checkin
f8ac3a9
@jmikeowen
Lot of renaming
6a5c976
@jmikeowen
Converting SPH classes to use PairwiseField for pair-accelerations.
7b55da6 
And some other cleanup...
@jmikeowen
Updating Python front-end constructor
f41931e
@jmikeowen
Initial conversion of SPH PYB11 package (untested)
56c4dd8
@jmikeowen
Updating thermal energy policies for PairwiseField use
04af076
@jmikeowen
Fixing some DataTypeTraits zeros, and making Python better respect co…
7f339ad 
…nfiguration choices such as which hydros to build.
@jmikeowen
SPH can now run using PairwiseField for pair accelerations, but the i…
0a08b64 
…nitialization order is not great
@jmikeowen
Merge branch 'develop' into bugfix/EvalDerivCleanup
b47d696
@jmikeowen
Making State and StateDerivatives not default constructable
83c46a1
@jmikeowen
Changing initialization order in Integrators and DataBase such that
92f85b8 
the ConnectivtyMap is available during construction of the State and
StateDerivatives. This is necessary to support pair-wise fields as
state members.
@jmikeowen
Clean up unused method
11d4e8a
@jmikeowen
Fixing a comment in SPH, and starting to convert CRK
89bd714
@jmikeowen
Simplifying dependencies for postion update, eps, and RZ cases
844414a
@jmikeowen
Initial conversion of CRKSPH to newer interface with PairwiseField
da23e11
@jmikeowen
Some SPH fixes with new interface
6cc6e02
@jmikeowen
PSPH needs to start inconsistently (need to fix this)
e576f2e
@jmikeowen
Got PSPH functioning
28625e3
@jmikeowen
FSISPH converted to PairwiseFields
2aa7d14
@jmikeowen
Converted GSPH to PairwiseField
09fc429
@jmikeowen
Moved how we build the State to be robust when not running a full
909bacb 
problem using the SpheralController
@jmikeowen
Removed unused option filter
2f09aeb
@jmikeowen
Fixed incorrect contract
6ebdba6
@jmikeowen
FSI conversion
0020b93
@jmikeowen
Initial conversion of SPH
1eb7d44
@jmikeowen
Converted CRK C++
99c2cd7
@jmikeowen
Compiles and links
3ba2735
@jmikeowen
Planar Noh tests are passing
e548163
@jmikeowen
Working through failing tests
47d0b1a
@jmikeowen
Fixed outdated graphics
1cc320e
@jmikeowen
Moving initialization of AV FieldList sizes to initializeProblemStartup
ee65a90
@jmikeowen
Updating for interface change to Morris-Monaghan and Cullen-Dehnen
5268d73 
reducing viscosity packages
@jmikeowen
Fix for spherical geometry
f66f675
@jmikeowen
Clean up warnings in optimized build
db68a19
@jmikeowen
Removing redundant Q constructor in test
fc6b8c4
@jmikeowen
Updated release notes
9b04100
@jmikeowen
Merge branch 'develop' into feature/ArtificialViscosityPackage
f43682c
@jmikeowen
Cleaning up State and StateDerivatives a bit, and allowing default co…
f2c49dd 
…nstruction
@jmikeowen
Changing DataBase::nodeListIndex to use size_t
dc02ef4
@jmikeowen
During initialization we have to be careful about recreating
a9b825b 
derivatives if connectivity has updated
@jmikeowen
On BlueOS with gcc we have some problem with using "any" without the
fed1318 
std:: prefix
@jmikeowen
Cleaning up warnings
77ef956
@jmikeowen
More warning cleanup
8cd72bf
@jmikeowen
Compile fix for blueos
4c3963e
@jmikeowen
Making NodePairList::Pair2Index lazy evaluation gets back most of the
c93a65a 
performance vs develop (about 90%)
@jmikeowen
Making PairwiseField allow more than one Value per pair as an optional
2b06fd7 
template parameter.  Let's us avoid using fields of std::pair or std::tuple.
@mdavis36 mdavis36 added this to the 2025.01.0 Release milestone Jan 3, 2025
@ptsuji ptsuji requested review from ptsuji and jmpearl January 9, 2025 17:40
@ptsuji
Copy link
Collaborator

ptsuji commented Jan 9, 2025

@jmikeowen - I'd like to test this branch against the SpheralC stuff. We will need the HydroFieldNames::viscousWork variable reinstated.

ptsuji
ptsuji reviewed Jan 9, 2025
View reviewed changes
src/SPH/CMakeLists.txt
SolidSPHHydroBaseRZ.hh
SolidSphericalSPHHydroBase.hh
PSPH.hh
SPHBase.hh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SpheralC stuff needs SPH.hh here.

ptsuji
ptsuji reviewed Jan 9, 2025
View reviewed changes
src/Utilities/DeprecationWarning.hh
@@ -0,0 +1,23 @@
//---------------------------------Spheral++----------------------------------//
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header needs to be added to the CMakeLists.txt file, otherwise the SpheralC stuff is missing the header.

@ldowen ldowen removed this from the 2025.01.0 Release milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptsuji ptsuji ptsuji left review comments

@jmpearl jmpearl Awaiting requested review from jmpearl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmikeowen @ptsuji @mdavis36 @ldowen