Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost with std library functionality (part 1) #258

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Replace boost with std library functionality (part 1) #258

wants to merge 10 commits into from

Conversation

adayton1
Copy link
Member

@adayton1 adayton1 commented Jan 25, 2024 •
edited
Loading

Summary

  • This PR is a feature
  • It does the following:
    • Removes unused boost includes and replaces boost calls whenever there is a std library drop in replacement

Future work:

  • Add hashing algorithms to Spheral (hash_combine, a hash specialization for std::pair)
  • Add string utility algorithms to Spheral (split)
  • Figure out what to do about boost python handle

@adayton1 adayton1 changed the title (WIP) Remove boost Replace boost with std library functionality (part 1) Jan 26, 2024
ptsuji
ptsuji reviewed Jan 29, 2024
View reviewed changes
src/Gravity/Tree.hh
@@ -59,7 +59,7 @@ public:
// Data types we use to build the internal tree structure.
typedef uint32_t LevelKey;
typedef std::pair<size_t, size_t> NodeID;
typedef boost::unordered_map<NodeID, std::vector<boost::unordered_set<CellKey> > > CompletedCellSet;
typedef boost::unordered_map<NodeID, std::vector<std::unordered_set<CellKey> > > CompletedCellSet;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be std::unordered_map?

ptsuji
ptsuji reviewed Jan 29, 2024
View reviewed changes
src/PYB11/Gravity/Tree.py
@@ -16,7 +16,7 @@ class Tree:
typedef uint64_t CellKey;
typedef uint32_t LevelKey;
typedef std::pair<size_t, size_t> NodeID;
typedef boost::unordered_map<NodeID, std::vector<boost::unordered_set<CellKey> > > CompletedCellSet;
typedef boost::unordered_map<NodeID, std::vector<std::unordered_set<CellKey> > > CompletedCellSet;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be std::unordered_map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptsuji ptsuji ptsuji left review comments

@jmikeowen jmikeowen Awaiting requested review from jmikeowen

@mdavis36 mdavis36 Awaiting requested review from mdavis36

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adayton1 @ptsuji