Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flux new api #407

Merged
merged 20 commits into from
Mar 28, 2023
Merged

Feature/flux new api #407

merged 20 commits into from
Mar 28, 2023

Conversation

koning
Copy link
Member

@koning koning commented Mar 22, 2023

Update to flux versions >= 0.48.x

@koning koning requested review from lucpeterson and bgunnar5 March 22, 2023 17:34
@koning
Copy link
Member Author

koning commented Mar 22, 2023

This is still a draft

koning and others added 4 commits March 22, 2023 10:49
fix bugs for stop-workers and schema validation

fix all flags for stop-workers

fix small bug with schema validation

modify CHANGELOG

run fix-style

add myself to contributors list

decouple celery logic from main

remove unused import

make changes Luc requested in PR
@koning
Copy link
Member Author

koning commented Mar 22, 2023

This include #405

Copy link
Member

@bgunnar5 bgunnar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to get this merged before I put in a PR for the batch.py refactor so I can include your changes there as well.

@koning
Copy link
Member Author

koning commented Mar 28, 2023

Ok , I'll wait for the pylint merge then merge that for your batch refactor.

@bgunnar5
Copy link
Member

The pylint fixes have been merged so once you pull changes you're good to merge this whenever.

Copy link
Member

@lucpeterson lucpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock and roll

@koning koning merged commit 535a4bf into develop Mar 28, 2023
@koning koning deleted the feature/flux_new_api branch October 9, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants