Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changing distconv overlaps in Identity layer. #2248

Merged
merged 12 commits into from
Jun 28, 2024

Conversation

fiedorowicz1
Copy link
Contributor

@fiedorowicz1 fiedorowicz1 commented Apr 14, 2023

Added support for changing distconv overlaps in the identity layer. Also added a corresponding unit test.

To improve the debugging experience, the overlap mismatch error message now indicates the offending layers.

@fiedorowicz1 fiedorowicz1 force-pushed the add-change-overlap branch 3 times, most recently from 7f63c6d to ccc64a8 Compare April 26, 2023 19:00
@fiedorowicz1 fiedorowicz1 marked this pull request as ready for review April 26, 2023 19:02
@fiedorowicz1 fiedorowicz1 requested a review from ndryden June 6, 2024 00:07
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If CI is happy, :shipit:

@fiedorowicz1
Copy link
Contributor Author

@bvanessen CI passed on all machines that were previously passing

@bvanessen bvanessen merged commit 602de5b into LLNL:develop Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants