Skip to content

Commit

Permalink
Fix is_participating for cross_grid_sum_slice
Browse files Browse the repository at this point in the history
  • Loading branch information
benson31 committed Jan 23, 2024
1 parent 6ecfb04 commit 36e0f3b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/lbann/layers/data_type_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class data_type_layer : public Layer
};

/** @brief Determine if we're participating in the compute on this process */
bool is_participating() const final;
bool is_participating() const override;

/** Forward propagation step.
* Apply a mathematical operation to input tensors to obtain output
Expand Down
2 changes: 1 addition & 1 deletion include/lbann/layers/transform/cross_grid_sum_slice.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class cross_grid_sum_slice_layer : public data_type_layer<TensorDataType>
this->setup_reference_counter(output);
}
}

bool is_participating() const final { return true; }
void bp_setup_gradient_wrt_inputs() override
{
auto children = this->get_child_layers();
Expand Down

0 comments on commit 36e0f3b

Please sign in to comment.