-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades the version of black used in CI #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilumsden It looks like you updated black - but reverted to the old version of flake. Why? If this is as intended, please update the PR title and description to have the desired version(s), and put the reason(s) for the version choice in the description.
@pearce8 I've updated the title and description. I was originally going to upgrade Regarding the part of your comment asking for a "reason for the version choice", the last sentence (shown below) covers that:
There wasn't any other complex reason for the choice. It was just the newest version supporting the Python version that we use when running |
FWIW, the issues I ran into with |
@draganagrbicllnl has been running into issues with
black
while trying to get formatting working in her PR #126. After looking at our CI, I realized we were using a 2.5 year old version ofblack
with quite a few known bugs. The version ofblack
we were using was particularly problematic since it was a beta version.This PR upgrades
black
in CI to the newest version that supports our target Python version (3.9).