-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Kripke comm dynamic #591
base: develop
Are you sure you want to change the base?
Conversation
@gracenansamba ok so in the experiment.py for kripke there is the variant code I show below, this is setting you to the develop version when you run experiment init, so you need to pass in
You should be able to do this as is, or you can update this code to look like Caliper's where you can list explicit values (you would just add comm_cali as a value):
|
…Kripke_Comm_dynamic
Added "https://github.com/gracenansamba/Kripke.git" path to /repo/kripke/package.py and adjusted other changes comparing to my old branch kripke_comm_cali
The current error is kripke@develop required in spack concretization.
May need to make a variant but was not successful.
added these lines for the new caliper metrics.
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper/modifier.py#L45C9-L45C10:
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper-mpi/modifier.py#L27