-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Naga] Dev Env #653
Closed
Closed
[Naga] Dev Env #653
+4,428
−1,011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd275fa
to
d4dfd95
Compare
1. include price feed info when we first connected, sort it from lowest to highest (default to true). 2. Added a new param `getNewPrices` if user want to fetch new prices from the contract. 3. created helper function to convert validator structs to urls
…na distrupt the tinny env init process
Closing this in favour of this #776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚧 In Progress - Don’t Merge
pull request is still under active development and should not be merged into the main branch. It sig
v8 | Naga
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: we should be merging v7 staging branch to here as frequently as possible
Update:
💡 This PR is ready to be used for developing against Naga.
Updates:
Blocked untilgetActiveUnkickedValidators
is added to the lit-assetsdevelop
branchCI blocked until a rc release is cutit's using this branch now https://github.com/LIT-Protocol/lit-assets/tree/rc-naga-2024-09-30/web/sign_session_key/v2
seems to be missing that's why CI is failing.. awaiting for confirmation ~Raised a PR.. awaiting reviews & approvals