Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hwrdtm/datil dev support #510

Closed
wants to merge 2 commits into from
Closed

Hwrdtm/datil dev support #510

wants to merge 2 commits into from

Conversation

hwrdtm
Copy link
Contributor

@hwrdtm hwrdtm commented Jun 20, 2024

Description

Work towards LIT-3404.

This PR:

  • Implements changes to support datil-dev as a Lit network, both in the core packages and also in the local-tests (Tinny). More importantly, this PR is INCOMPLETE ⚠️ ⚠️ ⚠️. It currently uses a hack to load in the network context for running against Datil-dev.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run DEBUG=true NETWORK=localchain LIT_RPC_URL=https://vesuvius-rpc.litprotocol.com yarn test:local to run against Datil-dev.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Datil Dev Network Context

networkContext.datilDev.json

@hwrdtm hwrdtm self-assigned this Jun 20, 2024
@hwrdtm
Copy link
Contributor Author

hwrdtm commented Jun 20, 2024

For now, I'm going to delegate this task to someone else and they can pick up on the PR where I've left off.

@Ansonhkg Ansonhkg requested a review from MaximusHaximus June 20, 2024 09:08
Copy link

@joshLong145 joshLong145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of the local-test changes

Comment on lines +323 to +326
// this._testnet = await this._shivaClient.startTestnetManager();
// // wait for the testnet to be active before we start the tests.
// await this._testnet.pollTestnetForActive();
// await this._testnet.getTestnetConfig();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a solution for this. could you revert this change?

@@ -380,7 +383,7 @@ export class TinnyEnvironment {
* ====================================
*/
if (this.network === LIT_TESTNET.LOCALCHAIN) {
const networkContext = this._testnet.ContractContext;
// const networkContext = this._testnet.ContractContext;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -101,7 +103,7 @@ export class TinnyPerson {
// * ====================================
// */
if (this.envConfig.network === LIT_TESTNET.LOCALCHAIN) {
const networkContext = this.envConfig.contractContext;
// const networkContext = this.envConfig.contractContext;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -15,9 +15,10 @@ import { TinnyEnvironment } from 'local-tests/setup/tinny-environment';
* - Then: The claim operation should successfully return signatures, derived key IDs, and validate the existence and structure of claimed results.
* *
* Test Commands:
* ❌ Not supported in Cayenne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this comment?

@@ -9,9 +9,10 @@ import { log } from '@lit-protocol/misc';

/**
* Test Commands:
* ❌ Not supported in Cayenne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this comment?

@@ -13,9 +13,10 @@ import { TinnyEnvironment } from 'local-tests/setup/tinny-environment';
* - Then: The claim operation should successfully return signatures, derived key IDs, and validate the existence and structure of claimed results.
* *
* Test Commands:
* ❌ Not supported in Cayenne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -7,9 +7,10 @@ import { TinnyEnvironment } from 'local-tests/setup/tinny-environment';

/**
* Test Commands:
* ❌ Not supported on cayenne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -5,9 +5,10 @@ import { TinnyEnvironment } from 'local-tests/setup/tinny-environment';

/**
* Test Commands:
* ❌ Not supported on cayenne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants