-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signMessage
and signTransaction
Lit Action exports for Wrapped Keys
#504
Add signMessage
and signTransaction
Lit Action exports for Wrapped Keys
#504
Conversation
…att/add-solana-actions
…att/add-solana-actions
signMessage
and signTransaction
Lit Action exports for Wrapped Keys
Let's add it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments. The idea is that I use these LitAction (ipfs_cid) in the functions: signTransactionWithEncryptedKey
, signMessageWithEncryptedKey
packages/wrapped-keys/src/lib/litActions/solana/src/signTransactionWithSolanaEncryptedKey.js
Outdated
Show resolved
Hide resolved
packages/wrapped-keys/src/lib/litActions/solana/src/signTransactionWithSolanaEncryptedKey.js
Outdated
Show resolved
Hide resolved
packages/wrapped-keys/src/lib/litActions/solana/src/signTransactionWithSolanaEncryptedKey.js
Show resolved
Hide resolved
packages/wrapped-keys/src/lib/litActions/solana/src/signTransactionWithSolanaEncryptedKey.js
Outdated
Show resolved
Hide resolved
packages/wrapped-keys/src/lib/litActions/solana/src/signTransactionWithSolanaEncryptedKey.js
Show resolved
Hide resolved
Also the Linter is failing, please run |
…eWithSolanaEncryptedKey.js Co-authored-by: DashKash54 <115020815+DashKash54@users.noreply.github.com> Signed-off-by: Wyatt Barnes <me@wyatt.email>
…ctionWithSolanaEncryptedKey.js Co-authored-by: DashKash54 <115020815+DashKash54@users.noreply.github.com> Signed-off-by: Wyatt Barnes <me@wyatt.email>
…eWithSolanaEncryptedKey.js Co-authored-by: DashKash54 <115020815+DashKash54@users.noreply.github.com> Signed-off-by: Wyatt Barnes <me@wyatt.email>
…ctionWithSolanaEncryptedKey.js Co-authored-by: DashKash54 <115020815+DashKash54@users.noreply.github.com> Signed-off-by: Wyatt Barnes <me@wyatt.email>
…eWithSolanaEncryptedKey.js Co-authored-by: DashKash54 <115020815+DashKash54@users.noreply.github.com> Signed-off-by: Wyatt Barnes <me@wyatt.email>
…-sdk into wyatt/add-solana-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments
486a0e4
into
feature/lit-3125-sdk-for-wrapping-up-walletx-2
NOTE Before this PR is merged, we need to pin the bundled Lit Action code via Lit's official Pinata account (or similar), as they are currently pinned via my personal Pinata account
Adds two exported
const
s fromwrapped-keys
package:signTransactionWithSolanaEncryptedKeyLitActionIpfsCid
serializedTransaction
by required a serialized transaction, we can support any Solana transaction signing (i.e. transfers or contract executions)broadcast
determines whether or not the signed transaction is submitted to thesolanaNetwork
solanaNetwork
is the Solana network to connect tomainnet-beta
,testnet
, anddevnet
signMessageWithSolanaEncryptedKeyLitActionIpfsCid
messageToSign
can be any string and is not expected to be encoded any specific way (it will be converted to aBuffer
before signing within the Lit Action)I tested that the sign tx and submit Lit Action works manually by providing it a testnet private key to the
testSignTransactionWithSolanaEncryptedKey
test and enabledbroadcast
(tx receipt)For organizational purposes, I renamed the Eth Lit Actions file to
ethereum.ts
and moved it under a newlitActions
directory. The Solana Lit Actions are located underlitActions/Solana