-
Notifications
You must be signed in to change notification settings - Fork 84
Feature/lit 3139 identify private methods in litnodeclient #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshLong145
merged 30 commits into
staging/v6
from
feature/lit-3139-identify-private-methods-in-litnodeclient
Jun 3, 2024
Merged
Feature/lit 3139 identify private methods in litnodeclient #482
joshLong145
merged 30 commits into
staging/v6
from
feature/lit-3139-identify-private-methods-in-litnodeclient
Jun 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neratepromise-function' into feature/lit-3139-identify-private-methods-in-litnodeclient
…ods-in-litnodeclient
…elper-functions-and-decouple-from-litnodeclient Feature/lit 3137 identify helper functions and decouple from litnodeclient
joshLong145
approved these changes
May 31, 2024
…ods-in-litnodeclient
…ods-in-litnodeclient Signed-off-by: Anson <ansonox@gmail.com>
joshLong145
pushed a commit
that referenced
this pull request
Jun 3, 2024
Revert "Merge pull request #482 from LIT-Protocol/feature/lit-3139-id…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to privatise, protect and remove unused methods from
lit-node-client
andlit-core
, standardise to use#methodFoo
over_methodFoo
for privatised methods, andprotected _methodBar
over_methodBar
for protected methods.NOTE: Even though we are implementing these method visibility changes using
#
for private methods andprotected _
for protected methods, it is important to note that these changes will only be fully effective with TypeScript and modern JavaScript (ES2022 and later). Core JavaScript prior to ES2022 does not natively support the#
syntax for private methods, and JS does not have a nativeprotected
keyword; this is a TypeScript feature that allows for better control over method visibility.Method Visibility Changes
Privatised Methods
The following methods have been changed to private (prefixed with #):
Protected Methods
The following methods have been changed to protected (prefixed with _):
Removed Methods and Endpoints
Type of change
How Has This Been Tested?
Checklist: