remove old v0 errors from js sdk. provide error details to the user (#…

…385) * remove old v0 errors from js sdk. provide error details to the user * building now seems to consistently work * refactored error handling to make it cleaner * Remove unused function * okay also added requestId in a few places * ran the linter * fix: replace nx executor * feat: add gitignore --------- Co-authored-by: Ansonhkg <ansonox@gmail.com>
LIT-Protocol · Feb 26, 2024 · 5464279 · 5464279
1 parent 1628810
commit 5464279
Show file tree

Hide file tree

Showing 41 changed files with 128 additions and 155 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.gitignore b/.gitignore
@@ -63,4 +63,6 @@ apps/html/index.html
 apps/nodejs/main.ts
 apps/react/src/app/app.tsx
 
-storage.test.db
+storage.test.db
+
+.nx
diff --git a/README.md b/README.md
diff --git a/apps/html/index.html b/apps/html/index.html
@@ -1,4 +1,4 @@
-<!-- (DO NOT EDIT!) (HTML) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-html.mjs Thu, 22 Feb 2024 05:05:54 GMT  -->
+<!-- (DO NOT EDIT!) (HTML) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-html.mjs Sat, 24 Feb 2024 04:18:12 GMT  -->
 <!DOCTYPE html>
 <html lang="en">
 <head>
@@ -62,7 +62,7 @@
 </style> 
 </head>
 <body>
-    (HTML) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-html.mjs Thu, 22 Feb 2024 05:05:54 GMT
+    (HTML) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-html.mjs Sat, 24 Feb 2024 04:18:12 GMT
 
     <!-- ==================== ALL EXPORTED VANILLA LIBRARIES ==================== -->
 

diff --git a/apps/react/src/app/app.tsx b/apps/react/src/app/app.tsx
@@ -1805,7 +1805,7 @@ pre {
                     `,
                 }}
             />
-            (REACT) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-react.mjs Thu, 22 Feb 2024 05:05:54 GMT
+            (REACT) THIS FILE IS AUTOMATICALLY GENERATED FROM tools/scripts/gen-react.mjs Sat, 24 Feb 2024 04:18:12 GMT
             <div id="root"></div>
              <pre><code id="result"></code></pre>
         </>

diff --git a/packages/access-control-conditions/package.json b/packages/access-control-conditions/package.json
@@ -23,5 +23,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/access-control-conditions/tsconfig.lib.json b/packages/access-control-conditions/tsconfig.lib.json
@@ -3,7 +3,8 @@
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
     "declaration": true,
-    "types": []
+    "types": [],
+    "explainFiles": true
   },
   "include": ["**/*.ts"],
   "exclude": ["jest.config.ts", "**/*.spec.ts", "**/*.test.ts"]

diff --git a/packages/auth-browser/package.json b/packages/auth-browser/package.json
@@ -32,5 +32,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/auth-helpers/package.json b/packages/auth-helpers/package.json
@@ -30,5 +30,5 @@
   },
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/bls-sdk/package.json b/packages/bls-sdk/package.json
@@ -29,5 +29,5 @@
   },
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/constants/package.json b/packages/constants/package.json
@@ -22,5 +22,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/constants/src/lib/constants/autogen_internal.ts b/packages/constants/src/lib/constants/autogen_internal.ts
@@ -1,5 +1,5 @@
-// Last Modified: 2024-02-26 06:49:39 
-  // This file is auto-generated by tools/scripts/gen-internal-dev.mjs
+// Last Modified: 2024-02-24 04:15:54
+// This file is auto-generated by tools/scripts/gen-internal-dev.mjs
 export const INTERNAL_DEV = [
   "https://167.114.17.205:443",
   "https://64.131.85.108:443",

diff --git a/packages/contracts-sdk/package.json b/packages/contracts-sdk/package.json
@@ -34,5 +34,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -26,5 +26,5 @@
     "universal"
   ],
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/core/src/lib/lit-core.ts b/packages/core/src/lib/lit-core.ts
@@ -929,29 +929,32 @@ export class LitCore {
    * @returns { void }
    *
    */
-  _throwNodeError = (res: RejectedNodePromises): void => {
-    if (res.error && res.error.errorCode) {
+  _throwNodeError = (res: RejectedNodePromises, requestId: string): void => {
+    if (res.error) {
       if (
-        (res.error.errorCode === LIT_ERROR_CODE.NODE_NOT_AUTHORIZED ||
+        ((res.error.errorCode &&
+          res.error.errorCode === LIT_ERROR_CODE.NODE_NOT_AUTHORIZED) ||
           res.error.errorCode === 'not_authorized') &&
         this.config.alertWhenUnauthorized
       ) {
-        log(
-          '[Alert originally] You are not authorized to access to this content'
-        );
+        log('You are not authorized to access this content');
       }
 
       throwError({
         ...res.error,
         message:
           res.error.message ||
-          'You are not authorized to access to this content',
-        errorCode: res.error.errorCode!,
+          'There was an error getting the signing shares from the nodes',
+        errorCode: res.error.errorCode || LIT_ERROR.UNKNOWN_ERROR.code,
+        requestId,
       } as NodeClientErrorV0 | NodeClientErrorV1);
     } else {
       throwError({
-        message: `There was an error getting the signing shares from the nodes`,
+        message: `There was an error getting the signing shares from the nodes.  Response from the nodes: ${JSON.stringify(
+          res
+        )}`,
         error: LIT_ERROR.UNKNOWN_ERROR,
+        requestId,
       });
     }
   };

diff --git a/packages/crypto/package.json b/packages/crypto/package.json
@@ -23,5 +23,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/ecdsa-sdk/package.json b/packages/ecdsa-sdk/package.json
@@ -26,5 +26,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/encryption/package.json b/packages/encryption/package.json
@@ -27,5 +27,5 @@
   },
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/lit-auth-client/package.json b/packages/lit-auth-client/package.json
@@ -31,5 +31,5 @@
     "nanoid": "3.3.4"
   },
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/lit-node-client-nodejs/package.json b/packages/lit-node-client-nodejs/package.json
@@ -26,5 +26,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts b/packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts
@@ -1344,7 +1344,7 @@ export class LitNodeClientNodeJs
   getSignatures = (signedData: Array<any>, requestId: string = ''): any => {
     const initialKeys = [...new Set(signedData.flatMap((i) => Object.keys(i)))];
 
-    // processing signature shares for failed or invalid contents.
+    // processing signature shares for failed or invalid contents.  mutates the signedData object.
     for (const signatureResponse of signedData) {
       for (const sigName of Object.keys(signatureResponse)) {
         const requiredFields = ['signatureShare'];
@@ -1436,10 +1436,10 @@ export class LitNodeClientNodeJs
         );
 
         throwError({
-          message:
-            'total number of valid signatures shares does not match threshold',
+          message: `The total number of valid signatures shares ${shares.length} does not meet the threshold of ${this.config.minNodeCount}`,
           errorKind: LIT_ERROR.NO_VALID_SHARES.kind,
           errorCode: LIT_ERROR.NO_VALID_SHARES.code,
+          requestId,
         });
       }
 
@@ -1598,7 +1598,7 @@ export class LitNodeClientNodeJs
     params = LitNodeClientNodeJs.normalizeParams(params);
 
     let res;
-    let requestId = this.getRequestId();
+    let requestId = '';
     // -- only run on a single node
     if (targetNodeRange) {
       res = await this.runOnTargetedNodes(params);
@@ -1649,7 +1649,7 @@ export class LitNodeClientNodeJs
     }
     // -- case: promises rejected
     if (res.success === false) {
-      this._throwNodeError(res as RejectedNodePromises);
+      this._throwNodeError(res as RejectedNodePromises, requestId);
     }
 
     // -- case: promises success (TODO: check the keys of "values")
@@ -1862,7 +1862,7 @@ export class LitNodeClientNodeJs
 
     // -- case: promises rejected
     if (!res.success) {
-      this._throwNodeError(res as RejectedNodePromises);
+      this._throwNodeError(res as RejectedNodePromises, requestId);
     }
 
     // -- case: promises success (TODO: check the keys of "values")
@@ -1991,7 +1991,6 @@ export class LitNodeClientNodeJs
     }
 
     // ========== Get Node Promises ==========
-    let requestId;
     const wrapper = async (
       id: string
     ): Promise<SuccessNodePromises<any> | RejectedNodePromises> => {
@@ -2036,10 +2035,11 @@ export class LitNodeClientNodeJs
       },
       this.config.retryTolerance
     );
+    const requestId = res.requestId;
 
     // -- case: promises rejected
     if (res.success === false) {
-      this._throwNodeError(res as RejectedNodePromises);
+      this._throwNodeError(res as RejectedNodePromises, requestId);
     }
 
     const signatureShares: Array<NodeBlsSigningShare> = (
@@ -2233,7 +2233,6 @@ export class LitNodeClientNodeJs
 
     log('identityParam', identityParam);
 
-    let requestId;
     // ========== Get Network Signature ==========
     const wrapper = async (
       id: string
@@ -2277,11 +2276,11 @@ export class LitNodeClientNodeJs
       this.config.retryTolerance
     );
 
-    requestId = res.requestId;
+    const requestId = res.requestId;
 
     // -- case: promises rejected
     if (res.success === false) {
-      this._throwNodeError(res as RejectedNodePromises);
+      this._throwNodeError(res as RejectedNodePromises, requestId);
     }
 
     const signatureShares: Array<NodeBlsSigningShare> = (
@@ -2618,7 +2617,7 @@ export class LitNodeClientNodeJs
 
     // -- case: promises rejected
     if (!this.#isSuccessNodePromises(res)) {
-      this._throwNodeError(res as RejectedNodePromises);
+      this._throwNodeError(res as RejectedNodePromises, requestId);
       return {} as SignSessionKeyResponse;
     }
 

diff --git a/packages/lit-node-client/package.json b/packages/lit-node-client/package.json
@@ -27,5 +27,5 @@
   },
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -10,5 +10,5 @@
     "directory": "../../dist/packages/logger"
   },
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/misc-browser/package.json b/packages/misc-browser/package.json
@@ -23,5 +23,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}
diff --git a/packages/misc/package.json b/packages/misc/package.json
@@ -26,5 +26,5 @@
   ],
   "version": "3.2.1",
   "main": "./dist/src/index.js",
-  "typings": "./dist/index.d.ts"
-}
+  "typings": "./dist/src/index.d.ts"
+}