Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler cleanliness patches and incorporation of HLS APT #1470

Merged
merged 21 commits into from
Sep 25, 2024
Merged

compiler cleanliness patches and incorporation of HLS APT #1470

merged 21 commits into from
Sep 25, 2024

Commits on Sep 20, 2024

  1. dont use a float as a for-loop counter 

    replace this with a while loop instead to be more clear about the possibility of rounding errors affecting performance
    @tomeichlersmith
    tomeichlersmith authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    05ff7e4 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary member variables holding digis, rename and align n… 

    …umbering of digi collections
    @tomeichlersmith
    tomeichlersmith committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2e584fe View commit details
    Browse the repository at this point in the history

  3. more compiler warning patches 

    - update digis{1,2,3} collection variable names
- remove useless (int) casts
- remove unused int index = count variables
    @tomeichlersmith
    tomeichlersmith committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4b4929 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary zero-ing of count after its use

    @tomeichlersmith
    tomeichlersmith committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0ad2f87 View commit details
    Browse the repository at this point in the history

  5. Apply clang-format

    @github-actions
    github-actions[bot] committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    840f7c3 View commit details
    Browse the repository at this point in the history

  6. dont specify HLS includes as a specific directory 

    we include them as a SYSTEM include in central CMakeLists.txt
and specifying them as SYSTEM informs CMake and its downstream compilers
to avoid analyzing them since they aren't our problem
    @tomeichlersmith
    tomeichlersmith committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    05b052f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. require value initialization in Firmware-mimic structs

    @tomeichlersmith
    tomeichlersmith committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8a387d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add checks in TrigScintFirmwareTracker, and fix array sizes, add defa… 

    …ults
    @tvami
    tvami committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    237d26c View commit details
    Browse the repository at this point in the history

  2. Resolve conflict

    @tvami
    tvami committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a850b8a View commit details
    Browse the repository at this point in the history

  3. copy HLS APT submodule into ldmx-sw proper under Tools

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    986e826 View commit details
    Browse the repository at this point in the history

  4. update readme notes

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    194d07c View commit details
    Browse the repository at this point in the history

  5. rename etc and hide private headers in the ap_impl directory

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f296659 View commit details
    Browse the repository at this point in the history

  6. fix up paths in includes so examples compile

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e9d54ff View commit details
    Browse the repository at this point in the history

  7. attach HLS APT headers as 'system' headers to Tools module

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6092212 View commit details
    Browse the repository at this point in the history

  8. remove inclusion of directory that doesn't exist anymore

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c7094fe View commit details
    Browse the repository at this point in the history

  9. patch inclusion of directories to correctly specify them as system he… 

    …aders
    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5af4b1e View commit details
    Browse the repository at this point in the history

  10. cleanup TS CMakeLists and specify Tools as dependency of Firmware

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ac82a91 View commit details
    Browse the repository at this point in the history

  11. add patch from PR #1 

    Xilinx/HLS_arbitrary_Precision_Types#1
    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a19fa5d View commit details
    Browse the repository at this point in the history

  12. wrap unknown pragmas in ifdef so they can be ignored here

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c59f45b View commit details
    Browse the repository at this point in the history

  13. remove unused centroid variable

    @tomeichlersmith
    tomeichlersmith committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c28ee81 View commit details
    Browse the repository at this point in the history

  14. Apply clang-format

    @github-actions
    github-actions[bot] committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bb7f5e3 View commit details
    Browse the repository at this point in the history