Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracking CI, add new CI action for LTO and modify other actions to use just #1462

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 17, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1459

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

Well the test of the pudding is to see what github does with these actions:

  • it does work according to the expectation

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great :) definitely a step in the right direction.

I don't really have any notes except a question. Do you think it would be helpful to summarize the default ci building in a just recipe to avoid copying it around?

[private]
ci-build: install-denv init (configure-force-error) build

(The parentheses help inform just that we aren't giving any more arguments to the configure step which would normally swallow all following arguments as build configuration.)

Then the CI calls would be

run: just ci-build

might be helpful, might not be.

@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

Hmm, I dont know, I see your point that this would certainly be much more compact, but I kinda like that it's spelled out, just for making it more obvious. And also it's more segmented right now in case some of the prev steps failed. So I'm kinda leaning forward keeping it as is.

@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

Compilation part looks good! Running the pn validation here
https://github.com/LDMX-Software/ldmx-sw/actions/runs/10911000232

@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

Compilation part looks good! Running the pn validation here https://github.com/LDMX-Software/ldmx-sw/actions/runs/10911000232

Yaay, ecalPN is back to work!

.github/workflows/pr_validation.yml Outdated Show resolved Hide resolved
@tvami tvami merged commit 0563d2d into trunk Sep 18, 2024
2 of 3 checks passed
@tvami tvami deleted the iss1459-misc-ci-updates branch September 18, 2024 14:32
@tvami tvami restored the iss1459-misc-ci-updates branch September 18, 2024 14:38
@tvami tvami deleted the iss1459-misc-ci-updates branch September 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to CI: use just, update tracking, enforce clang-tidy
3 participants