-
Notifications
You must be signed in to change notification settings - Fork 1
Updates to fix SimHits/Digi handling, follow enhances to the HGCROC emulator and corrections at Reco Level #9
Conversation
The tests are failing and it looks like you are just missing a line in your config(s): https://github.com/LDMX-Software/ldmx-sw/runs/2363421931#step:9:107 Maybe just need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Besides the call for a little more documentation, I can't see anything else. Time to release the hounds and get to validating on larger samples!
include/Hcal/HcalRecProducer.h
Outdated
mutable TGraph correctionAmpl_; | ||
mutable TGraph correctionTOA_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a perfect spot to put some documentation about how these corrections are calculated.
Using a multiline-doxygen comment, you'll have plenty of room and it will show up in the docs.
/**
* Correction to the pulse amplitude.
* This was calculated by...
*/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks Tom! Just updated the docs
Solves #7
Digitization:
Reconstruction:
Tester