This repository has been archived by the owner on May 9, 2024. It is now read-only.
Hcal Veto Fixes #23
Merged
Hcal Veto Fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omar-moreno I added some fixes to make the WAB veto work, let me know if this needs to be merged to another branch or something? |
|
Thanks Sophie, I'll take a look asap.
…On Wed, Feb 16, 2022 at 12:18 PM Sophie Middleton ***@***.***> wrote:
@omar-moreno <https://github.com/omar-moreno> I added some fixes to make
the WAB veto work, let me know if this needs to be merged to another branch
or something?
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4JMXHC2VHU7BYVWF6EUD3U3QBBPANCNFSM5OFNC4GA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
omar-moreno
approved these changes
Feb 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes since the reconstruction updated and shift some of the cuts. A further PR will be needed eventually. This veto vetos 100% of the WAB, 99.8% of the WAS and 99.9% of the WASB. This corresponds to 300 WAS and 23 WASB at 10^14 EOT so a final selection is needed but for now this is good.