WAB Veto

[sophiemiddleton]

First attempt at a WAB Veto - will require further work but seems fine for a first step.

[omar-moreno]

Do you have a talk or plots showing the performance of the veto? If so, can you link them to the PR for reference? Thanks!

…

On Wed, Jan 5, 2022, 1:22 AM Sophie Middleton ***@***.***> wrote: First attempt at a WAB Veto - will require further work but seems fine for a first step. ------------------------------ You can view, comment on, or merge this pull request online at: #20 Commit Summary - c34e701 <c34e701> made veto, tested - 52e3ebc <52e3ebc> works veto File Changes (5 files <https://github.com/LDMX-Software/Hcal/pull/20/files>) - *M* include/Hcal/HcalClusterProducer.h <https://github.com/LDMX-Software/Hcal/pull/20/files#diff-416c44711346af73cb94f9048e26cd812385f5f65a87adbe121d1ed02aff1834> (3) - *A* include/Hcal/HcalWABVetoProcessor.h <https://github.com/LDMX-Software/Hcal/pull/20/files#diff-3d75a48792453a72c00c40fcb1b8736cfcf65a145a3558705e060d9c2763ef48> (63) - *M* python/hcal.py <https://github.com/LDMX-Software/Hcal/pull/20/files#diff-228a2321bd69304d346310d4d208ce2c24c81b4b2d3463b7787a4e222a0e3a28> (25) - *M* src/Hcal/HcalClusterProducer.cxx <https://github.com/LDMX-Software/Hcal/pull/20/files#diff-f5fbf15c068e96455c0f3b965836005ae9a0f652a8f5dc75c958c05cc66a60be> (4) - *A* src/Hcal/HcalWABVetoProcessor.cxx <https://github.com/LDMX-Software/Hcal/pull/20/files#diff-dd6f340ecce39cce8aac444a31c9beeece40dfa9602fb71e3c2b38a197078924> (103) Patch Links: - https://github.com/LDMX-Software/Hcal/pull/20.patch - https://github.com/LDMX-Software/Hcal/pull/20.diff — Reply to this email directly, view it on GitHub <#20>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4JMXBHRZTMPAVNWUQWSFTUUQEUVANCNFSM5LJNOMBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sophiemiddleton]

Will do this, I am writing an Internal Note which will detail the Veto and all the WAB work. It's in the final stages and I can circulate it in the coming weeks. I'm at a conference this and next week but should be working in between talks to complete the document.

Do you have a talk or plots showing the performance of the veto? If so, can you link them to the PR for reference? Thanks!
…
On Wed, Jan 5, 2022, 1:22 AM Sophie Middleton @.> wrote: First attempt at a WAB Veto - will require further work but seems fine for a first step. ------------------------------ You can view, comment on, or merge this pull request online at: #20 Commit Summary - c34e701 <c34e701> made veto, tested - 52e3ebc <52e3ebc> works veto File Changes (5 files https://github.com/LDMX-Software/Hcal/pull/20/files) - M include/Hcal/HcalClusterProducer.h https://github.com/LDMX-Software/Hcal/pull/20/files#diff-416c44711346af73cb94f9048e26cd812385f5f65a87adbe121d1ed02aff1834 (3) - A include/Hcal/HcalWABVetoProcessor.h https://github.com/LDMX-Software/Hcal/pull/20/files#diff-3d75a48792453a72c00c40fcb1b8736cfcf65a145a3558705e060d9c2763ef48 (63) - M python/hcal.py https://github.com/LDMX-Software/Hcal/pull/20/files#diff-228a2321bd69304d346310d4d208ce2c24c81b4b2d3463b7787a4e222a0e3a28 (25) - M src/Hcal/HcalClusterProducer.cxx https://github.com/LDMX-Software/Hcal/pull/20/files#diff-f5fbf15c068e96455c0f3b965836005ae9a0f652a8f5dc75c958c05cc66a60be (4) - A src/Hcal/HcalWABVetoProcessor.cxx https://github.com/LDMX-Software/Hcal/pull/20/files#diff-dd6f340ecce39cce8aac444a31c9beeece40dfa9602fb71e3c2b38a197078924 (103) Patch Links: - https://github.com/LDMX-Software/Hcal/pull/20.patch - https://github.com/LDMX-Software/Hcal/pull/20.diff — Reply to this email directly, view it on GitHub <#20>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JMXBHRZTMPAVNWUQWSFTUUQEUVANCNFSM5LJNOMBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

[omar-moreno]

Before merging, I'll run clang-format. Will do that this afternoon.

[sophiemiddleton]

I see Clang failed - any ideas why? I based this on a fairly recent version of LDMX-sw so it sould be working fine

[omar-moreno]

@sophiemiddleton The failure is related to one of the files not using the google C++ style. I can fix it up while I'm testing the functionality of the PR.

[omar-moreno]

@sophiemiddleton Can you merge in the trunk. I can't do it because the changes live on a fork.

[sophiemiddleton]

OK, managed to push. Had to login and logout again, I guess my session had timed out or somehting. Should have the trunk merged now

[sophiemiddleton]

@omar-moreno What is the status of this?

[omar-moreno]

I'll merge this but a couple things for future PR's:

1. Please provide a procedure to test the PR. This includes a set of plots that can be used to compare against.
2. Make sure you are using the correct formatting i.e. clang-format with google style. Currently, this PR will not pass the format check.

[sophiemiddleton]

Thanks @omar-moreno I'll work on that next time. I'll check my formatting too.