Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Change PE and amplitude definition for RecHits #17

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Change PE and amplitude definition for RecHits #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1e1559
correct voltage by a factor of 2
cmantill Sep 1, 2021
c71adc3
change amplitude too
cmantill Sep 1, 2021
c828fac
fix typo
cmantill Sep 1, 2021
c46ef2e
add sampling fraction in test
cmantill Sep 1, 2021
9214abe
keep both sum and average and format
cmantill Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 34 additions & 11 deletions src/Hcal/HcalRecProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ void HcalRecProducer::configure(framework::config::Parameters& ps) {
if (n == 0) minAmpl_ = ampl_t;
n++;
}

}

double HcalRecProducer::getTOA(
Expand Down Expand Up @@ -164,6 +163,7 @@ void HcalRecProducer::produce(framework::Event& event) {
double voltage_min(0.);
double hitTime(0.);

double amplT(0.);
double amplT_posend(0.), amplTm1_posend(0.);
double amplT_negend(0.), amplTm1_negend(0.);

Expand Down Expand Up @@ -238,16 +238,19 @@ void HcalRecProducer::produce(framework::Event& event) {
// reverse voltage attenuation
// if position along the bar is positive, then the positive end will have
// less attenuation than the negative end
// NOTE: For now, reverse attenuation is not applied to the energy
// deposited since both ends of the bar are summed.
double att_posend =
exp(-1. * ((distance_posend - position_bar) / 1000.) / attlength_);
double att_negend =
exp(-1. * ((distance_negend + position_bar) / 1000.) / attlength_);

// set voltage
voltage = (voltage_posend / att_posend + voltage_negend / att_negend) /
2; // mV
voltage_min =
std::min(voltage_posend / att_posend, voltage_negend / att_negend);
// set voltage as the sum of both bars
voltage = (voltage_posend + voltage_negend);
voltage_min = std::min(voltage_posend, voltage_negend);

// set amplitude as the average of both bars (reverse attenuated)
amplT = (amplT_posend / att_posend + amplT_negend / att_negend) / 2;

// set position along the bar
if ((id_posend.layer() % 2) == 1) {
Expand Down Expand Up @@ -297,15 +300,18 @@ void HcalRecProducer::produce(framework::Event& event) {
attlength_);

// set voltage
voltage = voltage_i / att;
voltage_min = voltage_i / att;
voltage = voltage_i;
voltage_min = voltage_i;

// set amplitude (reverse attenuated)
amplT = amplT_posend / att;

// get TOA
double TOA =
getTOA(digi_posend, the_conditions.adcPedestal(id_posend), iSOI);

// correct TOA
TOA = correctionTOA_.Eval(amplT_posend) - TOA;
TOA = correctionTOA_.Eval(amplT) - TOA;

// set hit time
hitTime = TOA; // ns
Expand All @@ -316,7 +322,24 @@ void HcalRecProducer::produce(framework::Event& event) {
double num_mips_equivalent = voltage / voltage_per_mip_;
double energy_deposited = num_mips_equivalent * mip_energy_;

// reconstructed energy in the layer (approximate)
// TODO: need to incorporate corrections if necessary
/**
* Simple calculation of sampling fraction:
* Thickness per layer: scintillator (0.2cm) + steel (0.25cm)
* Radiation length and nuclear interaction length:
* scintillator: X0 = 41.31cm, Lambda = 77.07cm
*https://pdg.lbl.gov/2017/AtomicNuclearProperties/HTML/polystyrene.html
* steel X0 = 1.757cm, Lambda = 16.77cm
*https://pdg.lbl.gov/2012/AtomicNuclearProperties/HTML_PAGES/026.html Prob
*of EM interaction (e.g. pi0): thickness/X0*100 = (0.2/41.31)/ ((0.2/41.31)
*+ (0.25/1.757)) ~ 3.3% Prob of Had interaction (e.g. pi+/pi-): =
*(0.2/77.07)/ ((0.2/77.07) + (0.25/16.77)) ~ 15% Then e.g. for neutron
*assuming 1/3 pi0 and 2/3 pi+/- composition: sampling fraction ~
*(1/3)*3.3.% + (2/3)*15% ~ 11% energy of neutron = energy_deposited / 0.11;
*
* NOTE: For now, sampling fraction is not applied.
**/
double reconstructed_energy = energy_deposited;
tomeichlersmith marked this conversation as resolved.
Show resolved Hide resolved

int PEs = num_mips_equivalent * pe_per_mip_;
Expand All @@ -330,8 +353,8 @@ void HcalRecProducer::produce(framework::Event& event) {
recHit.setZPos(position.Z());
recHit.setPE(PEs);
recHit.setMinPE(minPEs);
recHit.setAmplitude(amplT_posend);
recHit.setEnergy(energy_deposited);
recHit.setAmplitude((amplT / voltage_per_mip_) * mip_energy_);
recHit.setEnergy(reconstructed_energy);
recHit.setTime(hitTime);
hcalRecHits.push_back(recHit);
}
Expand Down
42 changes: 23 additions & 19 deletions test/HcalDigiPipelineTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
#include "Framework/ConfigurePython.h"
#include "Framework/EventProcessor.h"
#include "Framework/Process.h"
#include "catch.hpp" //for TEST_CASE, REQUIRE, and other Catch2 macros

#include "SimCore/Event/SimCalorimeterHit.h"
#include "Recon/Event/HgcrocDigiCollection.h"
#include "Hcal/Event/HcalHit.h"
#include "Recon/Event/HgcrocDigiCollection.h"
#include "SimCore/Event/SimCalorimeterHit.h"
#include "catch.hpp" //for TEST_CASE, REQUIRE, and other Catch2 macros

namespace hcal {
namespace test {
Expand All @@ -28,17 +27,20 @@ static const double PE_ENERGY = 4.66 / 68; // 0.069 MeV
static const double MeV_per_mV = PE_ENERGY / 5; // 0.013 MeV/mV

/**
* Maximum error that a single hit energy
* Maximum error that a single hit energy/PE
* can be reconstructed with before failing the test
*
* Comparing energy deposited that was
* Comparing energy deposited/PE that was
* "simulated" (input into digitizer) and the reconstructed
* energy deposited output by reconstructor.
* energy deposited/PE output by reconstructor.
*
* NOTE: Currently Digitization not implemented for TOT mode
*/
static const double MAX_ENERGY_ERROR_DAQ = 4 * PE_ENERGY;
static const double MAX_ENERGY_PERCENT_ERROR_DAQ = 0.12;
// static const double MAX_ENERGY_ERROR_DAQ = 4 * PE_ENERGY;
// static const double MAX_ENERGY_PERCENT_ERROR_DAQ = 0.2;
static const double MAX_PE_ERROR_DAQ = 40;
static const double MAX_PE_PERCENT_ERROR_DAQ =
0.4; // large percentage error for now

/**
* Maximum error that a single hit position along the bar
Expand Down Expand Up @@ -267,19 +269,21 @@ class HcalCheckReconstruction : public framework::Analyzer {
ntuple_.setVar<float>("RecY", hit.getYPos());
ntuple_.setVar<float>("RecZ", hit.getZPos());
ntuple_.setVar<float>("RecTime", hit.getTime());
ntuple_.setVar<float>("RecPE", hit.getPE());
ntuple_.setVar<float>("RecEnergy", hit.getEnergy());
}

// define target energy by using the settings at the top
double daq_energy{hit.getEnergy()};
CHECK_THAT(daq_energy, isCloseEnough(truth_energy, MAX_ENERGY_ERROR_DAQ,
MAX_ENERGY_PERCENT_ERROR_DAQ));

// std::cout << "rec energy " << hit.getEnergy() << " truth " <<
// truth_energy
// << std::endl;

// ntuple_.setVar<float>("RecEnergy", hit.getEnergy());
// define target pe by using the settings at the top
double daq_pe{hit.getPE()};
CHECK_THAT(daq_pe, isCloseEnough(truth_energy / PE_ENERGY, MAX_PE_ERROR_DAQ,
MAX_PE_PERCENT_ERROR_DAQ));

// std::cout << "rec energy " << hit.getEnergy() << " * approx sampl
// fraction " << hit.getEnergy()*sampling_fraction << " truth " <<
// truth_energy
// << std::endl;
// std::cout << "npes " << hit.getPE() << " approx PE " << int(truth_energy
// / PE_ENERGY) << std::endl;

if (id.section() == 0) {
double truth_pos, rec_pos;
Expand Down
3 changes: 1 addition & 2 deletions test/HcalGeometryTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
#include "Framework/ConfigurePython.h"
#include "Framework/EventProcessor.h"
#include "Framework/Process.h"
#include "catch.hpp" //for TEST_CASE, REQUIRE, and other Catch2 macros

#include "SimCore/Event/SimCalorimeterHit.h"
#include "catch.hpp" //for TEST_CASE, REQUIRE, and other Catch2 macros

namespace hcal {
namespace test {
Expand Down