implement wrappy pFBA using the normal L2 wrappers #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stelmo I've got 1 remaining test fail on this, which is actually on ECModel (the result is like 89% instd of 91% of some enzyme). Could you pls check what might have gone wrong? Otherwise this is IMO gtg |
|
Will look now, could be the solver misbehaving though |
stelmo
approved these changes
Mar 5, 2023
Comment on lines
+199
to
+208
| # TODO here we would normally also overload the matrix function, but that | ||
| # one will break once anyone touches variables of the models (which is | ||
| # common). We should have a macro like @model_does_not_modify_variable_set | ||
| # that adds the overloads. Or perhaps AbstractModelWrapperWithSameVariables? | ||
| # | ||
| # The same probably goes for other semantics; | ||
| # AbstractModelWrapperThatOnlyTouchesSemantics(...) ? (Which has an | ||
| # alternative in forcing people to overload all semantic functions in all | ||
| # cases of adding semantics, which might actually be the right way.) | ||
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## mo-pfba-pipe #773 +/- ##
================================================
+ Coverage 88.02% 88.63% +0.61%
================================================
Files 91 89 -2
Lines 2280 2262 -18
================================================
- Hits 2007 2005 -2
+ Misses 273 257 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.