Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return enzyme concentrations in useful units #757

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Feb 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 88.49% // Head: 88.49% // No change to project coverage 👍

Coverage data is based on head (f515349) compared to base (33eef00).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #757   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          88       88           
  Lines        2103     2103           
=======================================
  Hits         1861     1861           
  Misses        242      242           
Impacted Files Coverage Δ
src/types/wrappers/EnzymeConstrainedModel.jl 92.68% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions:

  • SimplifiedEnzymeConstrainedModel does not need the same treatment?
  • do we want to enforce the "enzyme's mass" semantics for the whole enzyme semantics?

src/types/wrappers/EnzymeConstrainedModel.jl Outdated Show resolved Hide resolved
@stelmo
Copy link
Collaborator Author

stelmo commented Feb 17, 2023

So simplified enzyme does not have protein variables, so this is not needed there.
Not sure what you mean for the second question?

@stelmo stelmo merged commit 979d57c into next Feb 17, 2023
@stelmo stelmo deleted the mo-sensible-enzyme-map branch February 17, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants