Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPA ordering fix #733

Merged
merged 1 commit into from
Jan 28, 2023
Merged

GPA ordering fix #733

merged 1 commit into from
Jan 28, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jan 28, 2023

(direct consequence of unique use in #731 )

@exaexa exaexa requested a review from stelmo January 28, 2023 17:00
@exaexa exaexa added bug Something isn't working minor Easy fix with low priority, likely just cosmetic labels Jan 28, 2023
@exaexa exaexa added this to the v1.5 milestone Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 91.30% // Head: 91.25% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (74830b2) compared to base (ac27ca5).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #733      +/-   ##
===========================================
- Coverage    91.30%   91.25%   -0.05%     
===========================================
  Files           82       82              
  Lines         2184     2196      +12     
===========================================
+ Hits          1994     2004      +10     
- Misses         190      192       +2     
Impacted Files Coverage Δ
src/base/utils/gene_associations.jl 93.61% <84.61%> (-3.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit 6bb6a86 into develop Jan 28, 2023
@exaexa exaexa deleted the mk-gpa-ordering-fix branch January 28, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor Easy fix with low priority, likely just cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants