freeze SBML dictionary ordering #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hashtable ordering is more random than was expected; and the unpredictability caused bad/random results when processing large models in a distributed way. This forcibly freezes the order for SBMLModel so that the ordering issue is avoided completely and forever.
|
(I had to intern some code from SBML.jl, but hopefully for good.) |
Codecov ReportBase: 91.13% // Head: 91.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #706 +/- ##
===========================================
+ Coverage 91.13% 91.30% +0.16%
===========================================
Files 82 82
Lines 2155 2208 +53
===========================================
+ Hits 1964 2016 +52
- Misses 191 192 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
stelmo
reviewed
Dec 7, 2022
stelmo
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashtable ordering is more random than was expected; and the unpredictability caused bad/random results when processing large models in a distributed way.
This forcibly freezes the order for SBMLModel so that the ordering issue is avoided completely and forever.