Remove the banner #649
Merged
Remove the banner #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #649 +/- ##
===========================================
- Coverage 91.05% 91.01% -0.04%
===========================================
Files 82 81 -1
Lines 2012 2004 -8
===========================================
- Hits 1832 1824 -8
Misses 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
exaexa
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
After some discussion and a bit of tears about the banner having 😭 to go I'm OK with this.
Still, could we actually move the banner and version information into the module docs?
Like, if people type ?COBREXA, this (and the version information, etc.) could show up instead of the really completely useless README print-out.
exaexa
reviewed
Sep 2, 2022
|
I still don't think this is nice ... |
exaexa
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The banner is totally unnecessary + a cobratoolbox left over, 🪓 it for v2.0.