Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SBML writing #639

Merged
merged 3 commits into from
Jul 26, 2022
Merged

support SBML writing #639

merged 3 commits into from
Jul 26, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jul 15, 2022

title says it. Depends on SBML 1.0.1, not yet released. 1.1 (pretty new)

@github-actions
Copy link
Contributor

🟢  Commit babedb4 is formatted properly.

@exaexa exaexa changed the base branch from master to develop July 15, 2022 10:08
@exaexa
Copy link
Collaborator Author

exaexa commented Jul 25, 2022

depends on LCSB-BioCore/SBML.jl#225, which depends on JuliaPackaging/Yggdrasil#5224

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #639 (4356673) into develop (1cbb61a) will increase coverage by 0.40%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    90.29%   90.69%   +0.40%     
===========================================
  Files           79       79              
  Lines         1926     1935       +9     
===========================================
+ Hits          1739     1755      +16     
+ Misses         187      180       -7     
Impacted Files Coverage Δ
src/base/utils/gene_associations.jl 94.54% <ø> (+3.63%) ⬆️
src/base/types/SBMLModel.jl 84.90% <62.50%> (+0.59%) ⬆️
src/io/sbml.jl 85.71% <80.00%> (-14.29%) ⬇️
src/base/utils/Reaction.jl 97.43% <100.00%> (ø)
src/io/io.jl 88.88% <100.00%> (+7.63%) ⬆️
src/io/json.jl 100.00% <0.00%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb82de0...4356673. Read the comment docs.

@exaexa exaexa merged commit 07d0262 into develop Jul 26, 2022
@exaexa exaexa deleted the mk-writesbml branch July 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants