Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hyphens in gene names in GRRs #634

Merged
merged 2 commits into from
Jun 14, 2022
Merged

allow hyphens in gene names in GRRs #634

merged 2 commits into from
Jun 14, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jun 14, 2022

@exaexa exaexa requested a review from htpusa June 14, 2022 07:47
@exaexa exaexa changed the title allow hyphens in gene names in GRRs`: allow hyphens in gene names in GRRs Jun 14, 2022
@github-actions
Copy link
Contributor

🟥  Commit 40e348e requires formatting!

Required formatting changes summary:

 src/base/utils/gene_associations.jl | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #634 (ed2d4a8) into develop (083b9ef) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff            @@
##           develop     #634   +/-   ##
========================================
  Coverage    90.29%   90.29%           
========================================
  Files           79       79           
  Lines         1926     1926           
========================================
  Hits          1739     1739           
  Misses         187      187           
Impacted Files Coverage Δ
src/analysis/modifications/moment.jl 97.29% <ø> (ø)
src/base/utils/gene_associations.jl 90.90% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ca08d...ed2d4a8. Read the comment docs.

@github-actions
Copy link
Contributor

🟢  Commit ed2d4a8 is formatted properly.

@exaexa exaexa merged commit dca969a into develop Jun 14, 2022
@exaexa exaexa deleted the mk-tag-in-grr branch June 14, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants