Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gap filling algorithm #617

Merged
merged 8 commits into from
May 16, 2022
Merged

Add a gap filling algorithm #617

merged 8 commits into from
May 16, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 15, 2022

Add a basic gap filling algorithm, basically the same one as used by cobrapy

@stelmo stelmo added the feature New feature/functionality label May 15, 2022
@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟥  Commit bf019df requires formatting!

Required formatting changes summary:

 src/reconstruction/gapfill.jl  | 27 +++++++++++++--------------
 test/reconstruction/gapfill.jl | 19 +++++++------------
 2 files changed, 20 insertions(+), 26 deletions(-)

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, I suggested a few minor improvements

src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
test/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
src/reconstruction/gapfill.jl Outdated Show resolved Hide resolved
@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit b43f909 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟢  Commit aa08208 is formatted properly.

1 similar comment
@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟢  Commit aa08208 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟥  Commit 4edb1b3 requires formatting!

Required formatting changes summary:

 src/reconstruction/gapfill_minimum_reactions.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟥  Commit f8cd84a requires formatting!

Required formatting changes summary:

 src/reconstruction/gapfill_minimum_reactions.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@exaexa exaexa self-requested a review May 16, 2022 12:02
@github-actions
Copy link
Contributor

🟥  Commit 3a2be37 requires formatting!

Required formatting changes summary:

 src/base/types/wrappers/GeckoModel.jl | 4 ++--
 test/analysis/gecko.jl                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟢  Commit 3a2be37 is formatted properly.

src/base/constants.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🟥  Commit fa0dc91 requires formatting!

Required formatting changes summary:

 src/base/types/wrappers/GeckoModel.jl | 4 ++--
 test/analysis/gecko.jl                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

@cylon-x
Copy link
Collaborator

cylon-x commented May 16, 2022

🟢  Commit fa0dc91 is formatted properly.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #617 (fa0dc91) into develop (3cd91c2) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
+ Coverage    90.46%   90.47%   +0.01%     
===========================================
  Files           78       79       +1     
  Lines         1878     1922      +44     
===========================================
+ Hits          1699     1739      +40     
- Misses         179      183       +4     
Impacted Files Coverage Δ
src/reconstruction/gapfill_minimum_reactions.jl 90.69% <90.69%> (ø)
src/base/solver.jl 96.42% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2283284...fa0dc91. Read the comment docs.

@exaexa exaexa merged commit 3b355fb into develop May 16, 2022
@exaexa exaexa deleted the mo-gapfil branch May 16, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants