-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gap filling algorithm #617
Conversation
🟥 Commit bf019df requires formatting! Required formatting changes summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay, I suggested a few minor improvements
🟢 Commit b43f909 is formatted properly. |
🟢 Commit aa08208 is formatted properly. |
1 similar comment
🟢 Commit aa08208 is formatted properly. |
🟥 Commit 4edb1b3 requires formatting! Required formatting changes summary:
|
🟥 Commit f8cd84a requires formatting! Required formatting changes summary:
|
clean up the gapfilling code
🟥 Commit 3a2be37 requires formatting! Required formatting changes summary:
|
🟢 Commit 3a2be37 is formatted properly. |
🟥 Commit fa0dc91 requires formatting! Required formatting changes summary:
|
🟢 Commit fa0dc91 is formatted properly. |
Codecov Report
@@ Coverage Diff @@
## develop #617 +/- ##
===========================================
+ Coverage 90.46% 90.47% +0.01%
===========================================
Files 78 79 +1
Lines 1878 1922 +44
===========================================
+ Hits 1699 1739 +40
- Misses 179 183 +4
Continue to review full report at Codecov.
|
Add a basic gap filling algorithm, basically the same one as used by cobrapy