Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check format using github actions, implement the /format command #615

Merged
merged 3 commits into from
May 16, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented May 15, 2022

This implements the functionality required for finally closing #322 . Additionally this implements simple whitespace error checkers for eof newlines and trailing spaces.

I decided against opening purely technical shortlived PRs by the bot -- the /format command literally just pushes a single commit that can be erased if people don't like it. Also, the opening of PRs causes substantial clicking overhead (and a lot of noise in my mailbox), and seems more fragile.

The code needs to reach the default branch before the /format command will work.

Demo follows below.

PS. the PR includes a tiny change in the internals of GeckoModel that I saw while fixing the space errors and didn't want to make yet another gecko PR about it.

Confirmation that formatting is ok

image

Message about formatting deficiencies

image

Formatting command, success message and the commit

image

@exaexa exaexa added the quality improves maintainability and code clarity label May 15, 2022
@github-actions
Copy link
Contributor

🟥  Commit a294a6e requires formatting!

Required formatting changes summary:

 src/analysis/gecko.jl                 | 2 +-
 src/base/types/wrappers/GeckoModel.jl | 6 +++---
 test/analysis/gecko.jl                | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

@github-actions
Copy link
Contributor

🟥  Commit f8e52a6 requires formatting!

Required formatting changes summary:

 test/analysis/gecko.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@github-actions
Copy link
Contributor

🟢  Commit 84736d6 is formatted properly.

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #615 (a294a6e) into develop (581400d) will not change coverage.
The diff coverage is n/a.

❗ Current head a294a6e differs from pull request most recent head 84736d6. Consider uploading reports for the commit 84736d6 to get more accurate results

@@           Coverage Diff            @@
##           develop     #615   +/-   ##
========================================
  Coverage    90.29%   90.29%           
========================================
  Files           78       78           
  Lines         1876     1876           
========================================
  Hits          1694     1694           
  Misses         182      182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e4509...84736d6. Read the comment docs.

@github-actions
Copy link
Contributor

🟢  Commit cb98224 is formatted properly.

@github-actions
Copy link
Contributor

🟢  Commit 02ff9d9 is formatted properly.

@github-actions
Copy link
Contributor

🟢  Commit 0bd69ec is formatted properly.

@github-actions
Copy link
Contributor

🟢  Commit 9d47ecf is formatted properly.

Copy link
Member

@laurentheirendt laurentheirendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants