-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check format using github actions, implement the /format
command
#615
Conversation
🟥 Commit a294a6e requires formatting! Required formatting changes summary:
|
🟥 Commit f8e52a6 requires formatting! Required formatting changes summary:
|
🟢 Commit 84736d6 is formatted properly. |
Codecov Report
@@ Coverage Diff @@
## develop #615 +/- ##
========================================
Coverage 90.29% 90.29%
========================================
Files 78 78
Lines 1876 1876
========================================
Hits 1694 1694
Misses 182 182 Continue to review full report at Codecov.
|
84736d6
to
cb98224
Compare
🟢 Commit cb98224 is formatted properly. |
cb98224
to
02ff9d9
Compare
🟢 Commit 02ff9d9 is formatted properly. |
02ff9d9
to
0bd69ec
Compare
🟢 Commit 0bd69ec is formatted properly. |
0bd69ec
to
9d47ecf
Compare
🟢 Commit 9d47ecf is formatted properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome 🎉
This implements the functionality required for finally closing #322 . Additionally this implements simple whitespace error checkers for eof newlines and trailing spaces.
I decided against opening purely technical shortlived PRs by the bot -- the
/format
command literally just pushes a single commit that can be erased if people don't like it. Also, the opening of PRs causes substantial clicking overhead (and a lot of noise in my mailbox), and seems more fragile.The code needs to reach the default branch before the
/format
command will work.Demo follows below.
PS. the PR includes a tiny change in the internals of GeckoModel that I saw while fixing the space errors and didn't want to make yet another gecko PR about it.
Confirmation that formatting is ok
Message about formatting deficiencies
Formatting command, success message and the commit