Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument forwarding in find_biomass_reaction_ids #590

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Mar 17, 2022

see title. :D thanks Taneli for reporting!

@exaexa exaexa requested review from htpusa and stelmo March 17, 2022 13:28
@cylon-x
Copy link
Collaborator

cylon-x commented Mar 17, 2022

🟢  Commit d03f4e5 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented Mar 17, 2022

🟢  Commit 5ee72be is formatted properly.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #590 (5ee72be) into develop (e9e7dd1) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop     #590      +/-   ##
===========================================
+ Coverage    90.78%   90.80%   +0.01%     
===========================================
  Files           67       67              
  Lines         1704     1696       -8     
===========================================
- Hits          1547     1540       -7     
+ Misses         157      156       -1     
Impacted Files Coverage Δ
src/base/macros/serialized.jl 100.00% <ø> (ø)
src/base/utils/looks_like.jl 33.33% <0.00%> (ø)
src/base/types/CoreModelCoupled.jl 100.00% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8dd1b...5ee72be. Read the comment docs.

@exaexa exaexa merged commit 01b6779 into develop Mar 17, 2022
@exaexa exaexa deleted the mk-looks-like-params-semicolon branch March 17, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants