Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain the multi-gene knockouts better #553

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jan 9, 2022

Fixes #520

A complete fix might be better in the future (see #552).

@exaexa exaexa added the documentation Improvements or additions to documentation label Jan 9, 2022
@exaexa exaexa linked an issue Jan 9, 2022 that may be closed by this pull request
Fixes #520

A complete fix might be better in the future (see #552).
Copy link
Collaborator

@htpusa htpusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for the moment. The overlay idea sounds good.

@cylon-x
Copy link
Collaborator

cylon-x commented Jan 10, 2022

🟢  Commit 19a68da is formatted properly.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #553 (19a68da) into develop (ea0cce1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #553   +/-   ##
========================================
  Coverage    90.47%   90.47%           
========================================
  Files           67       67           
  Lines         1711     1711           
========================================
  Hits          1548     1548           
  Misses         163      163           
Impacted Files Coverage Δ
src/analysis/modifications/knockout.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0cce1...19a68da. Read the comment docs.

@exaexa exaexa merged commit 17c9187 into develop Jan 10, 2022
@exaexa exaexa deleted the mk-explain-ko-mod branch January 10, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are knockouts potentially confusing?
3 participants