Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the keyword arguments in new version of SBML #544

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Dec 27, 2021

...hopefully ending the series of single-version SBML-compatibility fixes once for all.

This requires SBML 0.9.1 which is not released yet, will merge this after LCSB-BioCore/SBML.jl#173 is tagged.

@exaexa exaexa requested a review from stelmo December 27, 2021 20:09
@cylon-x
Copy link
Collaborator

cylon-x commented Dec 27, 2021

🟢  Commit b6bd947 is formatted properly.

...hopefully ending the series of single-version compatibility
fixes once for all.
@cylon-x
Copy link
Collaborator

cylon-x commented Jan 4, 2022

🟢  Commit a87b3c4 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented Jan 4, 2022

🟢  Commit 9629381 is formatted properly.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #544 (9629381) into master (9d37f2d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   90.47%   90.46%   -0.01%     
==========================================
  Files          67       67              
  Lines        1711     1710       -1     
==========================================
- Hits         1548     1547       -1     
  Misses        163      163              
Impacted Files Coverage Δ
src/analysis/flux_balance_analysis.jl 100.00% <ø> (ø)
src/analysis/screening.jl 97.87% <ø> (ø)
src/base/types/SBMLModel.jl 85.41% <ø> (-0.30%) ⬇️
src/base/types/FluxVariabilitySummary.jl 90.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f8d88...9629381. Read the comment docs.

Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@exaexa exaexa merged commit 553ed70 into master Jan 4, 2022
@exaexa exaexa deleted the mk-sbml-091 branch January 4, 2022 13:15
exaexa added a commit that referenced this pull request Jan 6, 2022
This reverts commit 553ed70, reversing
changes made to 39f8d88.
exaexa added a commit that referenced this pull request Jan 6, 2022
Move the changes from #544 to `develop`
laurentheirendt added a commit that referenced this pull request Jan 6, 2022
Revert "Merge pull request #544 from LCSB-BioCore/mk-sbml-091"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants