Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some wording and make explanation clearer #529

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Nov 29, 2021

Minor wording changes for notebook 9, the thermodynamic one

@stelmo stelmo requested a review from exaexa November 29, 2021 09:15
@cylon-x
Copy link
Collaborator

cylon-x commented Nov 29, 2021

🟢  Commit 4ae89cb is formatted properly.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #529 (40c4704) into develop (2b2a84b) will decrease coverage by 0.27%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #529      +/-   ##
===========================================
- Coverage    90.77%   90.49%   -0.28%     
===========================================
  Files           67       67              
  Lines         1636     1663      +27     
===========================================
+ Hits          1485     1505      +20     
- Misses         151      158       +7     
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (-50.00%) ⬇️
src/analysis/max_min_driving_force.jl 92.98% <93.33%> (+0.12%) ⬆️
src/banner.jl 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9671d5a...40c4704. Read the comment docs.

@cylon-x
Copy link
Collaborator

cylon-x commented Nov 29, 2021

🟢  Commit 40c4704 is formatted properly.

@stelmo stelmo merged commit ac9b0de into develop Nov 29, 2021
@stelmo stelmo deleted the mo-cleanup-n9 branch November 29, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants