Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop→master #495

Merged
merged 47 commits into from
Nov 3, 2021
Merged

develop→master #495

merged 47 commits into from
Nov 3, 2021

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Nov 3, 2021

No description provided.

stelmo and others added 30 commits October 25, 2021 20:03
remove some of the repeated code, make MOMA more flexible
moma implementation and tests
run tests&docs on develop, trigger gitlab also on new tags
use the gitlab-documenter integration directly (attempt 1)
temporarily increase tolerance on the MOMA test (needs fixup later)
reflect the workflow change in contrib guide
Try to fix gitlab docbuilding deploy (attempt 2)
Reorganize the API docs to nice sections
Polish solution for all QP problems
@cylon-x
Copy link
Collaborator

cylon-x commented Nov 3, 2021

🟥  Commit 44d6448 requires formatting!

Required formatting changes summary:

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #495 (44d6448) into master (32ffaf3) will increase coverage by 0.72%.
The diff coverage is 91.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   90.42%   91.15%   +0.72%     
==========================================
  Files          65       67       +2     
  Lines        1598     1650      +52     
==========================================
+ Hits         1445     1504      +59     
+ Misses        153      146       -7     
Impacted Files Coverage Δ
src/analysis/modifications/moment.jl 97.22% <ø> (ø)
src/base/macros/serialized.jl 100.00% <ø> (ø)
src/base/types/FluxSummary.jl 85.00% <ø> (ø)
src/base/types/FluxVariabilitySummary.jl 90.47% <ø> (ø)
src/reconstruction/SerializedModel.jl 100.00% <ø> (ø)
src/base/utils/looks_like.jl 20.00% <20.00%> (-20.00%) ⬇️
src/base/utils/gene_associations.jl 87.27% <92.50%> (+28.18%) ⬆️
src/analysis/minimize_metabolic_adjustment.jl 100.00% <100.00%> (ø)
src/analysis/modifications/crowding.jl 100.00% <100.00%> (+29.41%) ⬆️
src/analysis/modifications/loopless.jl 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300a527...44d6448. Read the comment docs.

@exaexa exaexa requested a review from stelmo November 3, 2021 19:08
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@exaexa exaexa merged commit 4320c6d into master Nov 3, 2021
@exaexa exaexa deleted the develop branch November 3, 2021 22:20
docs/make.jl Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants