Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite julia version in notebooks to one compatible with binder #461

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Oct 13, 2021

This should fix #388 but needs checking, I didn't have a way to try it realistically yet.

@cylon-x
Copy link
Collaborator

cylon-x commented Oct 13, 2021

🟢  Commit d52be50 is formatted properly.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #461 (d52be50) into master (bec1685) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          61       61           
  Lines        1462     1462           
=======================================
  Hits         1306     1306           
  Misses        156      156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0560bd1...d52be50. Read the comment docs.

@laurentheirendt
Copy link
Member

Let's see if this fixes it 😄

@laurentheirendt laurentheirendt merged commit 2a99845 into master Oct 13, 2021
@laurentheirendt laurentheirendt deleted the mk-fix-binder branch October 13, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot find kernel - binder
3 participants