Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly forward the workers parameter #449

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Sep 7, 2021

Description

Amusing.

I wish this was the cause of the benchmark slowness. :D

@cylon-x
Copy link
Collaborator

cylon-x commented Sep 7, 2021

🟢  Commit d08bff8 is formatted properly.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #449 (d08bff8) into master (bc4bd82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          61       61           
  Lines        1464     1464           
=======================================
  Hits         1308     1308           
  Misses        156      156           
Impacted Files Coverage Δ
src/analysis/flux_variability_analysis.jl 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad630f...d08bff8. Read the comment docs.

Copy link
Member

@laurentheirendt laurentheirendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an important fix 😄

@laurentheirendt laurentheirendt merged commit aad22c6 into master Sep 7, 2021
@laurentheirendt laurentheirendt deleted the mk-fva-param branch September 7, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants