Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slightly improve the objective value handling at FVA #448

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Aug 31, 2021

...and finally allow the whole FBA part to be successfully and easily separated
into its own efficient single-threaded step.

I wanted to do this a long ago, finally we've got the opportunity here.

...and finally allow the whole FBA part to be successfully and easily separated
into its own efficient single-threaded step.
@exaexa exaexa requested a review from htpusa August 31, 2021 14:58
@cylon-x
Copy link
Collaborator

cylon-x commented Aug 31, 2021

🟢  Commit bc4bd82 is formatted properly.

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #448 (bc4bd82) into master (2854acd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          61       61           
  Lines        1464     1464           
=======================================
  Hits         1308     1308           
  Misses        156      156           
Impacted Files Coverage Δ
src/analysis/flux_variability_analysis.jl 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9348e...bc4bd82. Read the comment docs.

@exaexa exaexa merged commit 2ad630f into master Aug 31, 2021
@exaexa exaexa deleted the mk-sanitize-fva branch August 31, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants