Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve parametrization of objective_envelope #447

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Aug 30, 2021

Description

makes objective_envelope a bit more universal

Checklist

  • All code is formatted with
    JuliaFormatter
    (run using JuliaFormatter; format("path/to/COBREXA.jl");)
  • Tests work (try with ]test COBREXA)
  • All new functions have proper docstrings
  • no changes in docs

@cylon-x
Copy link
Collaborator

cylon-x commented Aug 30, 2021

🟢  Commit b90df72 is formatted properly.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #447 (b90df72) into master (2854acd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          61       61           
  Lines        1464     1464           
=======================================
  Hits         1308     1308           
  Misses        156      156           
Impacted Files Coverage Δ
src/analysis/envelopes.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9348e...b90df72. Read the comment docs.

@laurentheirendt laurentheirendt merged commit e57c592 into master Sep 9, 2021
@laurentheirendt laurentheirendt deleted the mk-parametrize-envelopes branch September 9, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants