Change set_bound to change_bound to fit in with CoreModel functions
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 87.51% 88.52% +1.00%
==========================================
Files 58 59 +1
Lines 1426 1446 +20
==========================================
+ Hits 1248 1280 +32
+ Misses 178 166 -12
Continue to review full report at Codecov.
|
exaexa
requested changes
Jun 18, 2021
stelmo
force-pushed
the
mo-homo-set-change-bound
branch
from
7775251
to
9f5309e
Compare
exaexa
reviewed
Jul 5, 2021
stelmo
force-pushed
the
mo-homo-set-change-bound
branch
from
9f5309e
to
3882c6a
Compare
|
🟥 Commit 3882c6a requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 78 ++++++++++++++++++----------
src/reconstruction/CoreModelCoupled.jl | 90 ++++++++++++++++++++++++---------
src/reconstruction/StandardModel.jl | 26 +++++++---
test/reconstruction/CoreModel.jl | 29 +++++++----
test/reconstruction/CoreModelCoupled.jl | 31 ++++++++----
test/reconstruction/StandardModel.jl | 24 ++++++---
7 files changed, 196 insertions(+), 88 deletions(-) |
|
🟥 Commit 0a94f77 requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 106 +++++++++++++++++++++-------
src/reconstruction/CoreModelCoupled.jl | 118 +++++++++++++++++++++++++-------
src/reconstruction/StandardModel.jl | 40 ++++++++---
test/reconstruction/CoreModel.jl | 29 +++++---
test/reconstruction/CoreModelCoupled.jl | 31 ++++++---
test/reconstruction/StandardModel.jl | 24 +++++--
7 files changed, 266 insertions(+), 88 deletions(-) |
|
🟥 Commit b7b8df6 requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 102 +++++++++++++++++++++-------
src/reconstruction/CoreModelCoupled.jl | 116 +++++++++++++++++++++++++-------
src/reconstruction/StandardModel.jl | 40 ++++++++---
test/reconstruction/CoreModel.jl | 29 +++++---
test/reconstruction/CoreModelCoupled.jl | 31 ++++++---
test/reconstruction/StandardModel.jl | 24 +++++--
7 files changed, 263 insertions(+), 85 deletions(-) |
|
🟥 Commit 7205fd1 requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 46 ++++++++++++++++++++++++++-------
src/reconstruction/CoreModelCoupled.jl | 36 ++++++++++++++++++++------
test/reconstruction/CoreModel.jl | 29 ++++++++++++++-------
test/reconstruction/CoreModelCoupled.jl | 31 +++++++++++++++-------
test/reconstruction/StandardModel.jl | 24 ++++++++++++-----
6 files changed, 133 insertions(+), 48 deletions(-) |
|
🟥 Commit 8972842 requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 95 +++++++++++++++++++++-------
src/reconstruction/CoreModelCoupled.jl | 109 +++++++++++++++++++++++++-------
src/reconstruction/StandardModel.jl | 40 +++++++++---
test/reconstruction/CoreModel.jl | 29 ++++++---
test/reconstruction/CoreModelCoupled.jl | 31 ++++++---
test/reconstruction/StandardModel.jl | 24 +++++--
7 files changed, 257 insertions(+), 86 deletions(-) |
|
🟥 Commit 14e4374 requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 95 +++++++++++++++++++++-------
src/reconstruction/CoreModelCoupled.jl | 109 +++++++++++++++++++++++++-------
src/reconstruction/StandardModel.jl | 40 +++++++++---
test/reconstruction/CoreModel.jl | 43 +++++++++----
test/reconstruction/CoreModelCoupled.jl | 31 ++++++---
test/reconstruction/StandardModel.jl | 37 +++++++----
7 files changed, 278 insertions(+), 92 deletions(-) |
|
🟥 Commit 1f6b229 requires formatting! Required formatting changes summary: 1 file changed, 11 insertions(+), 4 deletions(-) |
|
🟥 Commit ab6ac9a requires formatting! Required formatting changes summary: src/reconstruction/CoreModel.jl | 9 +++------
src/reconstruction/CoreModelCoupled.jl | 3 +--
3 files changed, 15 insertions(+), 12 deletions(-) |
|
🟥 Commit dd521c7 requires formatting! Required formatting changes summary: 1 file changed, 11 insertions(+), 4 deletions(-) |
1 similar comment
|
🟥 Commit dd521c7 requires formatting! Required formatting changes summary: 1 file changed, 11 insertions(+), 4 deletions(-) |
|
Hmm, no idea what is wrong with the format... @exaexa? |
stelmo
force-pushed
the
mo-homo-set-change-bound
branch
from
dd521c7
to
a4761a5
Compare
|
🟥 Commit a4761a5 requires formatting! Required formatting changes summary: 1 file changed, 11 insertions(+), 4 deletions(-) |
|
🟥 Commit a4761a5 requires formatting! Required formatting changes summary: |
exaexa
reviewed
Jul 9, 2021
|
🟢 Commit 9357e09 is formatted properly. |
1 similar comment
|
🟢 Commit 9357e09 is formatted properly. |
minimize the change_bound generator macro
|
🟢 Commit a67eaec is formatted properly. |
exaexa
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #329
@exaexa, should I also change
with_set_boundtowith_change_bound?