Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 ✨ Atoms in reactions and overall flux #312

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jun 8, 2021

Add a function to get the atoms exchanged by a reaction (should be zero for all reactions except the biomass and boundary reactions). See #311

Also fix issue with atom_exchange when applied to overall flux distribution.

Closes #311 when merged.

@stelmo stelmo added bug Something isn't working feature New feature/functionality labels Jun 8, 2021
@stelmo stelmo requested a review from exaexa June 8, 2021 13:36
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
EDIT: except for the tests failing

@stelmo
Copy link
Collaborator Author

stelmo commented Jun 8, 2021

looks good to me
EDIT: except for the tests failing

How important are those really?

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #312 (65f167b) into master (7e6d9fa) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   91.71%   91.75%   +0.04%     
==========================================
  Files          50       50              
  Lines        1146     1152       +6     
==========================================
+ Hits         1051     1057       +6     
  Misses         95       95              
Impacted Files Coverage Δ
src/base/utils/StandardModel.jl 89.47% <100.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55797f5...65f167b. Read the comment docs.

@laurentheirendt laurentheirendt merged commit 7194e65 into master Jun 8, 2021
@laurentheirendt laurentheirendt deleted the mo-fix-atoms branch June 8, 2021 14:24
laurentheirendt added a commit that referenced this pull request Jun 10, 2021
🩹 ✨ Atoms in reactions and overall flux

Former-commit-id: 7194e65
exaexa pushed a commit that referenced this pull request Jul 8, 2021
🩹 ✨ Atoms in reactions and overall flux

Former-commit-id: 7194e65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature/functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature to get atomic counts in reactions
3 participants