-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 ✨ Atoms in reactions and overall flux #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
EDIT: except for the tests failing
How important are those really? |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 91.71% 91.75% +0.04%
==========================================
Files 50 50
Lines 1146 1152 +6
==========================================
+ Hits 1051 1057 +6
Misses 95 95
Continue to review full report at Codecov.
|
🩹 ✨ Atoms in reactions and overall flux Former-commit-id: 7194e65
🩹 ✨ Atoms in reactions and overall flux Former-commit-id: 7194e65
Add a function to get the atoms exchanged by a reaction (should be zero for all reactions except the biomass and boundary reactions). See #311
Also fix issue with
atom_exchange
when applied to overall flux distribution.Closes #311 when merged.