Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing functions for CoreModelCoupled #307

Merged
merged 12 commits into from
Jun 8, 2021
Merged

Missing functions for CoreModelCoupled #307

merged 12 commits into from
Jun 8, 2021

Conversation

laurentheirendt
Copy link
Member

@htpusa , can you rebase?

@laurentheirendt laurentheirendt mentioned this pull request Jun 7, 2021
Closed
@laurentheirendt
Copy link
Member Author

I opened the PR from within this repo, as there is still #262 open

@codecov
Copy link

codecov bot commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #307 (f492833) into master (121a15a) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   91.26%   91.69%   +0.43%     
==========================================
  Files          49       49              
  Lines        1099     1132      +33     
==========================================
+ Hits         1003     1038      +35     
+ Misses         96       94       -2
Impacted Files Coverage Δ
src/reconstruction/CoreModel.jl 97.19% <ø> (+1.82%) ⬆️
src/reconstruction/CoreModelCoupled.jl 98.52% <100.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5374a4...f492833. Read the comment docs.

@htpusa htpusa mentioned this pull request Jun 7, 2021
Closed
htpusa
htpusa reviewed Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@htpusa htpusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now.

exaexa
exaexa approved these changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's okay now. We're going to add a tiny bit of reconstruction over this too.

@exaexa exaexa merged commit a0ed72f into master Jun 8, 2021
@exaexa exaexa deleted the htpusa-CoreModelCoupled branch June 8, 2021 06:54
laurentheirendt pushed a commit to laurentheirendt/COBREXA.jl that referenced this pull request Jun 8, 2021
@exaexa
Merge pull request LCSB-BioCore#307 from LCSB-BioCore/htpusa-CoreMode…
24f42f2 
…lCoupled

Missing functions for CoreModelCoupled

Former-commit-id: a0ed72f
exaexa added a commit that referenced this pull request Jul 8, 2021
@exaexa
Merge pull request #307 from LCSB-BioCore/htpusa-CoreModelCoupled
12de84c 
Missing functions for CoreModelCoupled

Former-commit-id: a0ed72f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htpusa htpusa htpusa left review comments

@exaexa exaexa exaexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentheirendt @exaexa @htpusa