Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add emoji references #304

Merged
merged 2 commits into from
Jun 7, 2021
Merged

📝 Add emoji references #304

merged 2 commits into from
Jun 7, 2021

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jun 7, 2021

Semantic descriptions (aka emojis) look pretty cool, add them to the contribution guidelines 😄

@stelmo stelmo added the documentation Improvements or additions to documentation label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #304 (4cfa201) into master (ce394f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          49       49           
  Lines        1102     1102           
=======================================
  Hits         1010     1010           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cd7a9...4cfa201. Read the comment docs.

@stelmo
Copy link
Collaborator Author

stelmo commented Jun 7, 2021

Also note, it seems Documenter.jl does not know what emojis are, so in the contribution guidelines there are 💡s and 👍s which do not get rendered.. They display fine on Github though

@laurentheirendt laurentheirendt merged commit 0bedce4 into master Jun 7, 2021
@laurentheirendt laurentheirendt deleted the mo-update-contribution branch June 7, 2021 14:06
laurentheirendt added a commit to laurentheirendt/COBREXA.jl that referenced this pull request Jun 8, 2021
…ibution

📝 Add emoji references

Former-commit-id: 0bedce4
exaexa pushed a commit that referenced this pull request Jul 8, 2021
📝 Add emoji references

Former-commit-id: 0bedce4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants