warmup jump+tulip code to save much time later in testing #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainly, this should prevent a situation where worker 1 and worker 2 do the precompilation sequentially, thus wasting 2*N time instead of just N. Actually, N is now around 50 seconds, so it saves quite a bit of time. Also, time measurements are now much less skewed by precompilation.
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 49 49
Lines 1138 1138
=======================================
Hits 1022 1022
Misses 116 116 Continue to review full report at Codecov.
|
laurentheirendt
pushed a commit
to laurentheirendt/COBREXA.jl
that referenced
this pull request
Jun 8, 2021
…izer warmup jump+tulip code to save much time later in testing Former-commit-id: d5374a4
exaexa
added a commit
that referenced
this pull request
Jul 8, 2021
warmup jump+tulip code to save much time later in testing Former-commit-id: d5374a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly, this should prevent a situation where worker 1 and worker 2 do the
precompilation sequentially, thus wasting 2*N time instead of just N. Actually,
N is now around 50 seconds, so it saves quite a bit of time. Also, time
measurements are now much less skewed by precompilation.
Closes #287