Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪓 Remove exchange_reactions #299

Merged
merged 2 commits into from
Jun 6, 2021
Merged

🪓 Remove exchange_reactions #299

merged 2 commits into from
Jun 6, 2021

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jun 5, 2021

This function is unnecessary after #297 is merged. The user can just find the exchanges themselves and display/use the flux dict themselves... The most useful part of this was to "pretty print" the result of some analysis function... which might be a good idea... but this will be for another PR.

@stelmo stelmo added the quality improves maintainability and code clarity label Jun 5, 2021
@stelmo
Copy link
Collaborator Author

stelmo commented Jun 5, 2021

This closes #288

@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #299 (c8f099a) into master (4d87f7b) will increase coverage by 1.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   89.80%   91.65%   +1.84%     
==========================================
  Files          49       49              
  Lines        1138     1102      -36     
==========================================
- Hits         1022     1010      -12     
+ Misses        116       92      -24     
Impacted Files Coverage Δ
src/base/utils/StandardModel.jl 100.00% <ø> (+35.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9bdd4...c8f099a. Read the comment docs.

@exaexa exaexa self-requested a review June 5, 2021 22:10
@stelmo stelmo merged commit 75cecb4 into master Jun 6, 2021
@stelmo stelmo deleted the mo-rm-verbose-utilities branch June 6, 2021 09:55
@stelmo stelmo mentioned this pull request Jun 6, 2021
laurentheirendt pushed a commit to laurentheirendt/COBREXA.jl that referenced this pull request Jun 8, 2021
…tilities

🪓 Remove `exchange_reactions`

Former-commit-id: 75cecb4
exaexa pushed a commit that referenced this pull request Jul 8, 2021
🪓 Remove `exchange_reactions`

Former-commit-id: 75cecb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve coverage of src/base/utils/StandardModel.jl
2 participants