🚚 Rename add! and rm! functions for StandardModel
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelmo
changed the title
add! and rm functions for StandardModeladd! and rm functions for StandardModel
stelmo
changed the title
add! and rm functions for StandardModeladd! and rm! functions for StandardModel
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 89.80% 89.74% -0.07%
==========================================
Files 49 49
Lines 1138 1131 -7
==========================================
- Hits 1022 1015 -7
Misses 116 116
Continue to review full report at Codecov.
|
|
closes #281 |
exaexa
approved these changes
Jun 5, 2021
laurentheirendt
pushed a commit
to laurentheirendt/COBREXA.jl
that referenced
this pull request
Jun 8, 2021
🚚 Rename `add!` and `rm!` functions for `StandardModel` Former-commit-id: 40547bd
exaexa
added a commit
that referenced
this pull request
Jul 8, 2021
🚚 Rename `add!` and `rm!` functions for `StandardModel` Former-commit-id: 40547bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CoreModeluses e.g.remove_reactionandadd_reactionetc. However,StandardModelusesadd!andrm!, this adds too much variability - the same method names should apply. HereStandardModel's functions are renamed.However, a slight issue remains that the functions are in place for
StandardModel, hence they have the bang!, while forCoreModelthey make a new model and are thus not in place. The user thus needs to remember to use the bang forStandardModels and not forCoreModels. This is slightly non-optimal... what do you think?