Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a problem in screening #273

Merged
merged 1 commit into from
May 23, 2021
Merged

fix a problem in screening #273

merged 1 commit into from
May 23, 2021

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented May 23, 2021

Reported by @stelmo

How come this didn't break with single-worker tests?

How come this didn't break with single-worker tests?
@exaexa exaexa requested a review from stelmo May 23, 2021 20:13
@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #273 (cf53296) into master (63fb40c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   87.59%   87.60%   +0.01%     
==========================================
  Files          49       49              
  Lines        1137     1138       +1     
==========================================
+ Hits          996      997       +1     
  Misses        141      141              
Impacted Files Coverage Δ
src/analysis/screening.jl 100.00% <100.00%> (ø)
src/base/types/abstract/MetabolicModel.jl 94.73% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa5751...cf53296. Read the comment docs.

@stelmo
Copy link
Collaborator

stelmo commented May 23, 2021

Reported by @stelmo

How come this didn't break with single-worker tests?

It works!! 💯

@stelmo stelmo merged commit 01ba93d into master May 23, 2021
@stelmo stelmo deleted the mk-fix-screening branch May 23, 2021 20:36
exaexa pushed a commit that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants