Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hit and run sampler #251

Merged
merged 30 commits into from
May 27, 2021
Merged

Fix hit and run sampler #251

merged 30 commits into from
May 27, 2021

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 11, 2021

Fix hit and run sampler to be production ready

@stelmo stelmo added draft performance reduces time and resource consumption labels May 11, 2021
@stelmo stelmo added this to the Release - v1.0.1 milestone May 12, 2021
src/analysis/sampling/hit_and_run.jl Outdated Show resolved Hide resolved
src/analysis/sampling/hit_and_run.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #251 (4198efd) into master (e70a9da) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   89.47%   89.80%   +0.32%     
==========================================
  Files          49       49              
  Lines        1150     1138      -12     
==========================================
- Hits         1029     1022       -7     
+ Misses        121      116       -5     
Impacted Files Coverage Δ
src/base/utils/StandardModel.jl 64.17% <ø> (-3.83%) ⬇️
src/analysis/flux_variability_analysis.jl 97.29% <100.00%> (+0.52%) ⬆️
src/analysis/sampling/affine_hit_and_run.jl 100.00% <100.00%> (ø)
src/analysis/sampling/warmup_variability.jl 100.00% <100.00%> (ø)
src/base/solver.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b87d8...4198efd. Read the comment docs.

@stelmo
Copy link
Collaborator Author

stelmo commented May 21, 2021

@exaexa so here are the almost working sampler functions. Basically everything works in serial, but the wheels fall of as soon as I add any compute nodes on my pc. See the testing functions test\analysis\sampling*.jl. I think the problem originates in warmup.jl... but I have no clue about what exactly the problem is or how to fix it

@exaexa exaexa merged commit 14e918e into master May 27, 2021
@exaexa exaexa deleted the mo-fix-hit-and-run branch May 27, 2021 10:41
exaexa added a commit that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance reduces time and resource consumption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants