Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genes and gene reaction rules to CoreModel #439

Closed
stelmo opened this issue Aug 14, 2021 · 3 comments · Fixed by #521
Closed

Add genes and gene reaction rules to CoreModel #439

stelmo opened this issue Aug 14, 2021 · 3 comments · Fixed by #521
Assignees
@exaexa @stelmo
Labels
feature New feature/functionality
Milestone
Release - v1.2

Comments

@stelmo
Copy link
Collaborator

stelmo commented Aug 14, 2021

The only really important feature missing from CoreModels is genes and gene reaction rules. What is the most efficient way to add this information to the models and still have it be efficient?
@stelmo stelmo added quality improves maintainability and code clarity performance reduces time and resource consumption feature New feature/functionality labels Aug 14, 2021
@stelmo stelmo added this to the Release - v1.0.4 milestone Aug 14, 2021
@exaexa exaexa removed quality improves maintainability and code clarity performance reduces time and resource consumption labels Aug 15, 2021
@exaexa
Copy link
Collaborator

exaexa commented Aug 15, 2021

are there any MAT models around that contain the GRRs?

@stelmo
Copy link
Collaborator Author

stelmo commented Aug 15, 2021

Yep, all the mat models from the BiGG database, e.g. iML1515, iJR904, iAF1260, etc.

@exaexa exaexa modified the milestones: Release - v1.1, Release - v1.2 Oct 28, 2021
@exaexa exaexa linked a pull request Nov 19, 2021 that will close this issue
Gene-reaction rules for CoreModel and CoreModelCoupled #439 #521
Merged
2 tasks
exaexa added a commit that referenced this issue Nov 22, 2021
@exaexa
Merge pull request #521 from LCSB-BioCore/tp-grr-coremodel
523c6eb 
Gene-reaction rules for CoreModel and CoreModelCoupled #439
@exaexa
Copy link
Collaborator

exaexa commented Nov 29, 2021

Closing this (thanks @htpusa ) 🎉

@exaexa exaexa closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exaexa exaexa

@stelmo stelmo

Labels
feature New feature/functionality
Projects
None yet
Milestone
Release - v1.2
Development

Successfully merging a pull request may close this issue.

Gene-reaction rules for CoreModel and CoreModelCoupled #439 LCSB-BioCore/COBREXA.jl
2 participants
@exaexa @stelmo