implement reviews

LCSB-BioCore · Nov 27, 2021 · d3103e9 · d3103e9
1 parent d585420
commit d3103e9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/analysis/max_min_driving_force.jl b/src/analysis/max_min_driving_force.jl
@@ -236,13 +236,15 @@ function max_min_driving_force_variability(
     workers = [myid()],
     optimal_objective_value = nothing,
     bounds = z -> (z, Inf),
+    modifications = [],
     kwargs...
 )
     if isnothing(optimal_objective_value)
             initsol = max_min_driving_force(
             model,
             reaction_standard_gibbs_free_energies,
             optimizer;
+            modifications,
             kwargs...
         )
         mmdf = initsol.mmdf
@@ -271,6 +273,7 @@ function max_min_driving_force_variability(
             m,
             reaction_standard_gibbs_free_energies,
             optimizer;
+            modifications = [args; modifications],
             kwargs...
         ),
         workers,

diff --git a/test/analysis/max_min_driving_force.jl b/test/analysis/max_min_driving_force.jl
@@ -49,9 +49,10 @@
         ignore_reaction_ids = ["H2Ot"],
         modifications = [change_optimizer_attribute("IPM_IterationsLimit", 1000)],
     )
+
     pyk_idx = first(indexin(["PYK"], reactions(model)))
     @test isapprox(
-        sols[pyk_idx].dg_reactions["PYK"],
+        sols[pyk_idx, 1].dg_reactions["PYK"],
         -1.5895040002691128;
         atol = TEST_TOLERANCE,
     )