Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Room.add_microphone_array discards MicrophoneArray directivity. #385

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

fakufaku
Copy link
Collaborator

@fakufaku fakufaku commented Dec 7, 2024

Fixes issue #382

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@fakufaku fakufaku self-assigned this Dec 7, 2024
@fakufaku fakufaku merged commit f6d11c9 into master Dec 7, 2024
38 checks passed
@fakufaku fakufaku deleted the fix/issue382 branch December 7, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room.add_microphone_array() loses array directivity when using MicrophoneArray class
1 participant